Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: limit test parallelism inmake test#19465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/make-test-ci-and-parallelism
Aug 21, 2025

Conversation

spikecurtis
Copy link
Contributor

In order to getmake test to reliably pass again on our dogfood workspaces, we're having to resort to setting parallelism.

It also reworks our CI to call themake test target, instead of rolling a different command.

Behavior changes:

  • sets 8 packages x 8 tests in parallel by default onmake test
  • by default, removes the-short flag. In my testing it makes only a few seconds difference on ~200s, or 1-2%
  • by default, removes the-count=1 flag that busts Go's test cache. With a fresh cache and no code changes,make test executes in ~15 seconds.

@spikecurtisspikecurtis changed the titlefix: add test parallelism limit to make testfix: limit test parallelism inmake testAug 21, 2025
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtisspikecurtisforce-pushed thespike/make-test-ci-and-parallelism branch from393f91c tocb78863CompareAugust 21, 2025 12:28
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎉

@spikecurtisspikecurtis merged commit72f58c0 intomainAug 21, 2025
30 checks passed
@spikecurtisspikecurtis deleted the spike/make-test-ci-and-parallelism branchAugust 21, 2025 12:37
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@dannykopping@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp