Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: addcheck-build job to requiremake build to pass on prs#19460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 4 commits intomainfromethan/notify-slack-on-build-fail
Aug 21, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 21, 2025•
edited
Loading

We've hadbuild fail on main one or two times, and it's easily preventable by just runningmake build on PRs.

I didn't addbuild to required as it's already pretty complex, and we'd be making it more complex by skipping half of it when not on coder/coder main.

@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 21, 2025 01:27
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Add build to required

@ethanndicksonethanndickson changed the titleci: send slack notif on main build failuresci: addcheck-build job to requiremake build to pass on prsAug 21, 2025
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

forgot to include the comment in review oops

@ethanndicksonethanndickson merged commit444874d intomainAug 21, 2025
33 checks passed
@ethanndicksonethanndickson deleted the ethan/notify-slack-on-build-fail branchAugust 21, 2025 07:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp