Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

expand README files for examples#1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
khorne3 merged 8 commits intomainfromexamples
Jun 6, 2022
Merged

expand README files for examples#1946

khorne3 merged 8 commits intomainfromexamples
Jun 6, 2022

Conversation

khorne3
Copy link
Contributor

Currently features the following so that no one sees empty files:

  • How to use it
  • Any gotchas

I'm open to any and all changes suggested. I'm tracking#1321 for future additions regarding troubleshooting

@khorne3khorne3 requested a review frombpmctJune 1, 2022 14:53
Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks for doing this! This is a larger question beyond this PR, but:

  1. do you have thoughts on how the product can refer to these docs during template creation? We have found that in many cases, we want to recommend users make edits to the TF instead of using the built-in example to manage access/secrets in their preferred way.
  2. I noticed some of this info is repeated based on the cloud configuration, not the template itself. Perhaps not a big deal yet, but we may be able to find another solution once we build a static docs site

@khorne3
Copy link
ContributorAuthor

@bpmct let me think a bit re: your questions and I'll get back to you!

Co-authored-by: Ben Potter <ben@coder.com>
@khorne3
Copy link
ContributorAuthor

Re:#1: I think some of the usage instructions are too long for us to consistently populate to the CLI, but maybe a link to instructions. I don't know if this is a bit too janky

Re:#2: yeah, if we could find a way to use templating to populate in repeated info, that would be really nice

bpmct reacted with thumbs up emoji

@khorne3khorne3 marked this pull request as ready for reviewJune 3, 2022 14:53
@khorne3khorne3 requested a review frombpmctJune 3, 2022 14:53
@khorne3khorne3 merged commit318e979 intomainJun 6, 2022
@khorne3khorne3 deleted the examples branchJune 6, 2022 18:03
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bpmctbpmctbpmct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@khorne3@bpmct

[8]ページ先頭

©2009-2025 Movatter.jp