Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add actionlint and zizmor linters#19459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deansheather merged 7 commits intomainfromdean/zizmor
Aug 21, 2025
Merged

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedAug 21, 2025
edited
Loading

Copilot

This comment was marked as outdated.

Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds two GitHub Actions linters (actionlint and zizmor) to improve security and quality of GitHub workflow files. The changes include creating a wrapper script for the zizmor Docker image, updating the Makefile to include the new linters, and fixing all linting errors across multiple workflow files.

  • Adds actionlint linter for GitHub Actions workflows
  • Adds zizmor linter (Docker-based) for GitHub Actions security scanning
  • Fixes shell quoting, environment variable usage, and other linting issues throughout workflow files

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
scripts/zizmor.shNew wrapper script for running zizmor linter via Docker
MakefileAdds actionlint and zizmor lint targets to the build system
.github/workflows/*.yamlFixes shell quoting, variable substitution, and security issues
.github/actions/*/action.yamlUpdates action definitions to fix quoting and variable usage
docs/tutorials/testing-templates.mdFixes shell quoting in code example

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

ethanndickson reacted with thumbs up emoji
Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm 🤞 🤞 🤞

Copy link
Contributor

@jdomeracki-coderjdomeracki-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's go! 🚀

@deansheatherdeansheather merged commit8d0bc48 intomainAug 21, 2025
35 checks passed
@deansheatherdeansheather deleted the dean/zizmor branchAugust 21, 2025 12:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 21, 2025
.PHONY: lint/actions

lint/actions/actionlint:
go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pinning version in Makefile makes it difficult to upgrade, as Dpendabot doesn't detect them.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali left review comments

Copilot code reviewCopilotCopilot left review comments

@ethanndicksonethanndicksonethanndickson approved these changes

@jdomeracki-coderjdomeracki-coderjdomeracki-coder approved these changes

Assignees

@deansheatherdeansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@deansheather@matifali@ethanndickson@jdomeracki-coder

[8]ページ先頭

©2009-2025 Movatter.jp