Aug 21, 2025 · Aug 20, 2025 · Aug 20, 2025 · Aug 20, 2025 · Aug 21, 2025 · Aug 21, 2025
diff --git a/coderd/database/check_constraint.go b/coderd/database/check_constraint.go
diff --git a/coderd/database/dump.sql b/coderd/database/dump.sql
diff --git a/coderd/database/migrations/000361_username_length_constraint.down.sql b/coderd/database/migrations/000361_username_length_constraint.down.sql
 ALTER TABLE users
 DROP CONSTRAINT IF EXISTS users_username_min_length;
diff --git a/coderd/database/migrations/000361_username_length_constraint.up.sql b/coderd/database/migrations/000361_username_length_constraint.up.sql
 ALTER TABLE users
 ADD CONSTRAINT users_username_min_length
 CHECK (length(username) >= 1);
diff --git a/coderd/database/querier_test.go b/coderd/database/querier_test.go

 // When: attempting to update a system user's name.
 _, err = db.UpdateUserProfile(ctx, database.UpdateUserProfileParams{
 ID:   systemUser.ID,
 Name: "not prebuilds",
 ID:        systemUser.ID,
 Email:     systemUser.Email,
 Username:  systemUser.Username,
 AvatarURL: systemUser.AvatarURL,
 Name:      "not prebuilds",
 })
 // Then: the attempt is rejected by a postgres trigger.
 // require.ErrorContains(t, err, "Cannot modify or delete system users")
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		ALTER TABLE users
		DROP CONSTRAINT IF EXISTS users_username_min_length;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		ALTER TABLE users
		ADD CONSTRAINT users_username_min_length
		CHECK (length(username) >= 1);
Copy link Contributor dannykoppingAug 21, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I wonder if we should expand this constraint to take the other clauses into account: https://github.com/coder/coder/blob/main/codersdk/name.go#L41-L60 In any case, enforcing the minimum solves our immediate problem so I'm approving, but we might be overfitting. Copy link Member johnstcnAug 21, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I don't think we need to duplicate the entire logic here. Copy link Contributor dannykoppingAug 21, 2025• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I'm not advocating for duplicating so much as replacing the logic; should've been more explicit.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1552,8 +1552,11 @@ func TestUpdateSystemUser(t *testing.T) {

		// When: attempting to update a system user's name.
		_, err = db.UpdateUserProfile(ctx, database.UpdateUserProfileParams{
		ID: systemUser.ID,
		Name: "not prebuilds",
		ID: systemUser.ID,
		Email: systemUser.Email,
		Username: systemUser.Username,
		AvatarURL: systemUser.AvatarURL,
		Name: "not prebuilds",
		})
		// Then: the attempt is rejected by a postgres trigger.
		// require.ErrorContains(t, err, "Cannot modify or delete system users")
Expand Down