- Notifications
You must be signed in to change notification settings - Fork1k
fix: fix flake due to two time.Now() calls#19450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
bcpeinhardt merged 1 commit intomainfrombcpeinhardt/TestSchecduleOverride/extend-flakefixAug 20, 2025
Merged
fix: fix flake due to two time.Now() calls#19450
bcpeinhardt merged 1 commit intomainfrombcpeinhardt/TestSchecduleOverride/extend-flakefixAug 20, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| now:=time.Now() | ||
| // To avoid the likelihood of time-related flakes, only matching up to the hour. | ||
| expectedDeadline:=time.Now().In(loc).Add(10*time.Hour).Format("2006-01-02T15:") | ||
| expectedDeadline:=now.In(loc).Add(10*time.Hour).Format("2006-01-02T15:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The culprit
f0ssel approved these changesAug 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🕙
02fc173 intomain 40 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
fixescoder/internal#559
This test is looking to see that after calling
coder schedule extend <workspace> 10h, the scheduled stop time of the workspace is updated appropriately (or at least that the information printed to the terminal indicates that).By using two
time.Now()calls for the current time and the expected time, there was the possibility that the second call just barely crossed over the hour mark. This is shown in the error message when the test would flake:wanted "2025-04-07T22:"; got " 2025-04-07T23:00:00+05:30 \r\n"(the 00:00 letting us know we just barely crossed the hour).Using the same time object to construct the expected time should fix the issue.