Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix workspaces pagination#19448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 5 commits intomainfrombq/18707
Aug 21, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletionssite/src/api/api.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1187,9 +1187,9 @@ class ApiMethods {
};

getWorkspaces = async (
options: TypesGen.WorkspacesRequest,
req: TypesGen.WorkspacesRequest,
): Promise<TypesGen.WorkspacesResponse> => {
const url = getURLWithSearchParams("/api/v2/workspaces",options);
const url = getURLWithSearchParams("/api/v2/workspaces",req);
const response = await this.axios.get<TypesGen.WorkspacesResponse>(url);
return response.data;
};
Expand Down
11 changes: 5 additions & 6 deletionssite/src/api/queries/workspaces.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -139,15 +139,14 @@ async function findMatchWorkspace(q: string): Promise<Workspace | undefined> {
}
}

function workspacesKey(config: WorkspacesRequest = {}) {
const { q, limit } = config;
return ["workspaces", { q, limit }] as const;
function workspacesKey(req: WorkspacesRequest = {}) {
return ["workspaces", req] as const;
}

export function workspaces(config: WorkspacesRequest = {}) {
export function workspaces(req: WorkspacesRequest = {}) {
return {
queryKey: workspacesKey(config),
queryFn: () => API.getWorkspaces(config),
queryKey: workspacesKey(req),
queryFn: () => API.getWorkspaces(req),
} as const satisfies QueryOptions<WorkspacesResponse>;
}

Expand Down
61 changes: 61 additions & 0 deletionssite/src/pages/WorkspacesPage/WorkspacesPage.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -305,6 +305,67 @@ describe("WorkspacesPage", () => {
MockStoppedWorkspace.latest_build.template_version_id,
);
});

it("correctly handles pagination by including pagination parameters in query key", async () => {
const totalWorkspaces = 50;
const workspacesPage1 = Array.from({ length: 25 }, (_, i) => ({
...MockWorkspace,
id: `page1-workspace-${i}`,
name: `page1-workspace-${i}`,
}));
const workspacesPage2 = Array.from({ length: 25 }, (_, i) => ({
...MockWorkspace,
id: `page2-workspace-${i}`,
name: `page2-workspace-${i}`,
}));

const getWorkspacesSpy = jest.spyOn(API, "getWorkspaces");

getWorkspacesSpy.mockImplementation(({ offset }) => {
switch (offset) {
case 0:
return Promise.resolve({
workspaces: workspacesPage1,
count: totalWorkspaces,
});
case 25:
return Promise.resolve({
workspaces: workspacesPage2,
count: totalWorkspaces,
});
default:
return Promise.reject(new Error("Unexpected offset"));
}
});

const user = userEvent.setup();
renderWithAuth(<WorkspacesPage />);

await waitFor(() => {
expect(screen.getByText("page1-workspace-0")).toBeInTheDocument();
});

expect(getWorkspacesSpy).toHaveBeenLastCalledWith({
q: "owner:me",
offset: 0,
limit: 25,
});

const nextPageButton = screen.getByRole("button", { name: /next page/i });
await user.click(nextPageButton);

await waitFor(() => {
expect(screen.getByText("page2-workspace-0")).toBeInTheDocument();
});

expect(getWorkspacesSpy).toHaveBeenLastCalledWith({
q: "owner:me",
offset: 25,
limit: 25,
});

expect(screen.queryByText("page1-workspace-0")).not.toBeInTheDocument();
});
});

const getWorkspaceCheckbox = (workspace: Workspace) => {
Expand Down
3 changes: 2 additions & 1 deletionsite/src/pages/WorkspacesPage/WorkspacesPage.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,7 +116,8 @@ const WorkspacesPage: FC = () => {
});

const workspacesQueryOptions = workspaces({
...pagination,
limit: pagination.limit,
offset: pagination.offset,
q: filterState.filter.query,
});
const { data, error, refetch } = useQuery({
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp