- Notifications
You must be signed in to change notification settings - Fork1k
fix: redirect users to/login
if their oauth token is invalid#19429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
brettkolodny merged 5 commits intomainfrombrett/oauth-token-expiry-doesn-t-trigger-re-auAug 20, 2025
Merged
fix: redirect users to/login
if their oauth token is invalid#19429
brettkolodny merged 5 commits intomainfrombrett/oauth-token-expiry-doesn-t-trigger-re-auAug 20, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Emyrk approved these changesAug 20, 2025
ee789da
intomain 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As mentioned in the issue the problem here is the fact this endpoint is returning a 401 instead of a 200 in this specific case.
Since we actually have enough information before performing this mutation to know that it'll fail in the case of a bad auth token we'd ideally re-work the code not to call the mutation on logout and just perform the local clean up. Unfortunately it seems like the interactions that this mutation is having with React Query at large is necessary for our code to work as intended and thus it's not currently possible to move the local clean up (the code inside of the
onSuccess
) outside of the mutation. Shout out to@Parkreiner for helping me confirm this.So until we can re-work the
AuthProvider
to be less brittle this PR changesonSuccess
toonSettled
so that while the mutation still fails with a 401, the local clean up still runs.Closes#12056