Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: redirect users to/login if their oauth token is invalid#19429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

brettkolodny
Copy link
Contributor

@brettkolodnybrettkolodny commentedAug 19, 2025
edited
Loading

As mentioned in the issue the problem here is the fact this endpoint is returning a 401 instead of a 200 in this specific case.

Since we actually have enough information before performing this mutation to know that it'll fail in the case of a bad auth token we'd ideally re-work the code not to call the mutation on logout and just perform the local clean up. Unfortunately it seems like the interactions that this mutation is having with React Query at large is necessary for our code to work as intended and thus it's not currently possible to move the local clean up (the code inside of theonSuccess) outside of the mutation. Shout out to@Parkreiner for helping me confirm this.

So until we can re-work theAuthProvider to be less brittle this PR changesonSuccess toonSettled so that while the mutation still fails with a 401, the local clean up still runs.

Closes#12056

@brettkolodnybrettkolodny merged commitee789da intomainAug 20, 2025
27 checks passed
@brettkolodnybrettkolodny deleted the brett/oauth-token-expiry-doesn-t-trigger-re-au branchAugust 20, 2025 19:04
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@aslilacaslilacAwaiting requested review from aslilacaslilac is a code owner

Assignees

@brettkolodnybrettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oauth token expiry doesn't trigger re-authentication in dashboard
2 participants
@brettkolodny@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp