Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(scaletest): add tls to infrastructure#19412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/tls-scaletest
Aug 25, 2025

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 19, 2025•
edited
Loading

Closescoder/internal#850

This PR has the scaletest infrastructure retrieve and use TLS certificates from the persistent observability cluster.

To support creating multiple instances of the infrastructure simultaneously,var.name can be set toalpha,bravo orcharlie, which retrieves the corresponding certificates.

Also:

  • Adds support for wildcard apps.
  • Retrieves the Cloudflare token from GCP secrets.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 19, 2025•
edited
Loading

@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 19, 2025 14:25
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Most of my comments are nitpicks but LGTM. Deferring to Spike for approval since I contributed

@ethanndicksonethanndickson changed the titlefeat: add tls to scaletest infrastructurechore: add tls to scaletest infrastructureAug 20, 2025
@ethanndicksonethanndickson changed the titlechore: add tls to scaletest infrastructurechore(scaletest): add tls to infrastructureAug 22, 2025
@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 25, 2025•
edited
Loading

Merge activity

  • Aug 25, 2:24 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Aug 25, 2:25 AM UTC:@ethanndickson merged this pull request withGraphite.

@ethanndicksonethanndickson merged commit5145cd0 intomainAug 25, 2025
27 of 28 checks passed
@ethanndicksonethanndickson deleted the ethan/tls-scaletest branchAugust 25, 2025 02:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather left review comments

@spikecurtisspikecurtisspikecurtis approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TLS to Coder control plane and proxies in scale test

4 participants

@ethanndickson@spikecurtis@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp