- Notifications
You must be signed in to change notification settings - Fork1k
fix(enterprise): update external agent instructions in cli#19411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
| pty.ExpectRegexMatch("curl -fsSL .* | CODER_AGENT_TOKEN=.* sh") | ||
| <-doneChan | ||
| testutil.TryReceive(context.Background(),t,doneChan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs to use a context with a timeout, e.g.ctx := testutil.Context(t, testutil.WaitLong)
Also, you should probably useRequireRecv instead for these, since you want the test to fail if the doneChan never gets closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nevermind, you need to useTryReceive, you're right.
c429020 intomainUh oh!
There was an error while loading.Please reload this page.
Description
The command for agent instructions was incorrectly displayed in the CLI.