- Notifications
You must be signed in to change notification settings - Fork1k
fix: resolveTestAPI/Error/DuringInjection flake#19407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| coderBin,err:=os.Executable() | ||
| require.NoError(t,err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It looks like this might sometimes be a symlink which we aren't resolving which causes a problem in the tests on nightly gauntlet. Instead of resolving this symlink, I've just removed this and replaced the mock expectation withgomock.Any() as we don't really care about this for this test.
| err=api.RefreshContainers(ctx) | ||
| require.NoError(t,err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
drive by fix: whilst trying to recreate this flake, i got this to fail because the clock would skip a turn for some reason, so instead we just invokeRefreshContainers directly.
e879526 intomainUh oh!
There was an error while loading.Please reload this page.
Resolvescoder/internal#905