- Notifications
You must be signed in to change notification settings - Fork1k
feat: show workspace health error alert above agents in WorkspacePage#19400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| )} | ||
| {!workspace.health.healthy&&( | ||
| <Alertseverity="warning"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Alert's background color is--surface-secondary. The buttons turn--surface-secondary on hover, so there's no apparent change when hovering. (This is also the case inWorkspaceNotifications.)
Does it make sense to keep these colors? Or should we do something like giveNotificationActionButton an even lighter background (--surface-tertiary) on hover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the existing popup has the same problem. it should definitely get fixed eventually but our colors are a bit of a mess right now. probably out of scope for this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
while you're poking at this, could I get you to update theMockUnhealthyWorkspace entity a little more for me? I think it's a bit more "realistic" if the agent is actually in an error state, as that affects some other styling on the page. I came up with...
exportconstMockUnhealthyWorkspace:TypesGen.Workspace={...MockWorkspace,id:"test-unhealthy-workspace",health:{healthy:false,failing_agents:[MockWorkspaceAgent.id],},latest_build:{...MockWorkspace.latest_build,resources:[{...MockWorkspaceResource,agents:[{...MockWorkspaceAgent,status:"timeout",lifecycle_state:"start_error",health:{healthy:false},},],},],},};
it might even be worth splitting into aMockUnhealthyAgent if you want but I'll leave it up to you
Uh oh!
There was an error while loading.Please reload this page.
| )} | ||
| {!workspace.health.healthy&&( | ||
| <Alertseverity="warning"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the existing popup has the same problem. it should definitely get fixed eventually but our colors are a bit of a mess right now. probably out of scope for this issue.
Good idea. These stories make a lot more visual sense now that the agent is red instead of blue  |
9a872f9 intomainUh oh!
There was an error while loading.Please reload this page.
closes#19338