- Notifications
You must be signed in to change notification settings - Fork1k
chore: improve scroll behavior of DashboardLayout wrapped pages#19396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
8b316d7
6062c75
e49317c
9b9f421
57f715d
a740ac5
4f18c8b
c4b0601
75e39f4
52b689f
2e7353b
9b06fdb
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -76,7 +76,7 @@ const GroupsPage: FC = () => { | ||
} | ||
return ( | ||
<div className="w-full max-w-screen-2xl pb-10"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Is there any way we can refactor the layouts to bake the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I believe I tried doing that, but the pages aren't set up consistently so it didn't end up being feasible. And making the pages more consistent seemed out of scope for this PR | ||
{helmet} | ||
<Stack | ||
@@ -107,7 +107,7 @@ const GroupsPage: FC = () => { | ||
canCreateGroup={permissions.createGroup} | ||
groupsEnabled={groupsEnabled} | ||
/> | ||
</div> | ||
); | ||
}; | ||
Uh oh!
There was an error while loading.Please reload this page.