- Notifications
You must be signed in to change notification settings - Fork1k
fix: avoid error when AI usage is zero#19388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixes a bug that prevents the managed AI agent usage from showing in thelicenses page of the dashboard when the usage is zero.
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| constusage=managedAgentFeature.actual??0; | ||
| constincluded=managedAgentFeature.soft_limit??0; | ||
| constlimit=managedAgentFeature.limit??0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
not coercing these to0 was intentional. if we get past theenabled check then these need to be some positive integer. (except usage, which can also be 0)
site/src/pages/DeploymentSettingsPage/LicensesSettingsPage/ManagedAgentsConsumption.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
67da780 intomainUh oh!
There was an error while loading.Please reload this page.
Fixes a bug that prevents the managed AI agent usage from showing in the licenses page of the dashboard when the usage is zero. Adds a story with this case as well.
!usageis true whenusage == 0.