- Notifications
You must be signed in to change notification settings - Fork1k
chore: set editorconfig to use spaces instead of tabs for sql files#19344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
indent_style =space | ||
indent_size =4 | ||
[coderd/database/queries/*.sql] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[coderd/database/queries/*.sql] | |
[*.sql] |
it'd be nice if everything was included. we could reformat migrations, or at least format them going forward. with all of the views we have that need to be recreated when you edit an underlying table stuff ends up getting copied and pasted around a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The one I was avoiding wasdump.sql
which is generated bypg_dump
and uses spaces. I don't want an editor config formatter to cause diffs in an autogenerated file.
I can extend this to migrations
e92af2b
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Use spaces consistently in
*.sql
filesEvery file needs to be corrected 😢
Not going to do that in this PR