Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: set editorconfig to use spaces instead of tabs for sql files#19344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 6 commits intomainfromstevenmasley/sql_tabs_to_spaces
Aug 15, 2025

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedAug 13, 2025
edited
Loading

Use spaces consistently in*.sql files

Every file needs to be corrected 😢

Not going to do that in this PR

@EmyrkEmyrk changed the titlechore: editorconfig to use spaces over tabs for sqlchore: set editorconfig to use spaces instead of tabs for sql filesAug 13, 2025
@EmyrkEmyrk requested a review fromaslilacAugust 14, 2025 15:24
indent_style =space
indent_size =4

[coderd/database/queries/*.sql]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
[coderd/database/queries/*.sql]
[*.sql]

it'd be nice if everything was included. we could reformat migrations, or at least format them going forward. with all of the views we have that need to be recreated when you edit an underlying table stuff ends up getting copied and pasted around a lot.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The one I was avoiding wasdump.sql which is generated bypg_dump and uses spaces. I don't want an editor config formatter to cause diffs in an autogenerated file.

I can extend this to migrations

@EmyrkEmyrk merged commite92af2b intomainAug 15, 2025
24 checks passed
@EmyrkEmyrk deleted the stevenmasley/sql_tabs_to_spaces branchAugust 15, 2025 13:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp