Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: keep original token refresh error in external auth#19339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 5 commits intomainfromstevenmasley/refresh_error_raise
Aug 14, 2025

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedAug 13, 2025
edited
Loading

External auth refresh errors lose the original error thrown on the first refresh. This PR saves that error to the database to be raised on subsequent refresh attempts

Addresses:#18811

The issue assumed refresh tokens were being tossed for temporary issues (like an IdP being down). We have code to handle this, however the original error being lost made that code invisible. By keeping the original error, now the reason for the token being invalid is saved (assuming it is a refresh error).

Error now

Screenshot From 2025-08-13 10-48-20Screenshot From 2025-08-13 10-48-05

Before

This is the behavior before. The first time this failure occurs, it is raised. Subsequent errors always showError: token expired, refreshing is either disabled or refreshing failed and will not be retried. This subsequent error makes it difficult to debug the original cause.

Screencast.From.2025-08-13.10-29-11.webm

Future work

The error could be better formatted. This PR does not attempt to update the error format, it just retains the first error message.

@EmyrkEmyrk marked this pull request as ready for reviewAugust 13, 2025 16:59
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

mostly makes sense to me, though I'm not very familiar with external auth stuff. might be worth waiting to see if someone else comes along to review.

External auth refresh errors lose the original error thrown on thefirst refresh. This PR saves that error to the database to be raisedon subsequent refresh attempts
@EmyrkEmyrkforce-pushed thestevenmasley/refresh_error_raise branch fromcccd7ae tob0a1694CompareAugust 14, 2025 14:23
@EmyrkEmyrk merged commit4926410 intomainAug 14, 2025
44 of 47 checks passed
@EmyrkEmyrk deleted the stevenmasley/refresh_error_raise branchAugust 14, 2025 14:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Emyrk@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp