- Notifications
You must be signed in to change notification settings - Fork1k
chore: improve message when running develop.sh multiple times#19333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
DanielleMaywood left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Tested with./scripts/develop.sh running and it worked well. Also tested withpython3 -m http.server 8080 andpython3 -m http.server 3000 and worked for both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested a minor cleanup, otherwise LGTM!
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
f17ab92 intomainUh oh!
There was an error while loading.Please reload this page.
This should help with part ofcoder/internal#854 |
develop.shchecks for existing processes listening on port 3000 or 8080.We can check if it's the development server to avoid confusion.