Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: correct markup for Abbr component#19317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Parkreiner merged 6 commits intomainfrommes/abbr-fix
Aug 14, 2025
Merged

fix: correct markup for Abbr component#19317

Parkreiner merged 6 commits intomainfrommes/abbr-fix
Aug 14, 2025

Conversation

Parkreiner
Copy link
Member

@ParkreinerParkreiner commentedAug 12, 2025•
edited
Loading

Fixes some accidental styling issues introduced in#19242

Changes made

  • Updated styles
  • Added support forclassName prop so that we can override the styles as needed
  • Removed the aria-label in favor of injecting the main text directly

Notes

  • This feels like a case where the changes in the previous PR were actuallycorrect overall, but something with our MUI+Tailwind setup created conflicting styles, and we accidentally introduced an underline style that shouldn't be there
  • Removed the Aria label because I've realized in the past year that Aria is really easy to misuse, and it's best just to do things with the base HTML features as much as possible. There's a risk that the old code had compliance issues with certain types of screen readers (even though it worked fine when I did manual testing back in 2023). These changes hopefully remove those risks completely

@ParkreinerParkreiner self-assigned thisAug 12, 2025
@ParkreinerParkreiner marked this pull request as ready for reviewAugust 13, 2025 21:18
pronunciation:Pronunciation;
};

functionassertAccessibleLabel({
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Got rid of the test helper because it felt like we were binding all our tests to a shallow abstraction

children===children.toUpperCase()
?"tracking-wide"
:"tracking-normal",
"no-underline tracking-normal",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wish we understood where the underline is coming from. these kinds of conflicts are so annoying. can we at least add a TODO to clean this up one day?

Copy link
MemberAuthor

@ParkreinerParkreinerAug 14, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So, the funny thing is,abbr elements have an underline by default in normal HTML – it's MUI that somehow overrode it

I actually don't think we should do anything – once MUI is out, we should be much closer to "normal" CSS, and this behavior would be 100% expected

@ParkreinerParkreiner merged commit0c203b0 intomainAug 14, 2025
27 checks passed
@ParkreinerParkreiner deleted the mes/abbr-fix branchAugust 14, 2025 04:20
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@ParkreinerParkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Parkreiner@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp