- Notifications
You must be signed in to change notification settings - Fork1k
chore(coderd/database/dbauthz): migrate more tests to mocked db#19300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…n OIDC claims, WorkspaceProxy, ProvisionerKeys)\n\n- Convert tests to s.Mocked\n- Add gomock expectations for fetch and authorized paths\n- Remove unused imports\n\nCo-authored-by: hugodutka <28019628+hugodutka@users.noreply.github.com>
- Convert DBCrypt subtests to s.Mocked with gomock expectations- Remove reliance on real DB for setup- Keeps consistent style with prior groups
- Convert CryptoKeys subtests to s.Mocked with gomock expectations- Return proper values for methods that return rows- Aligns with prior mocked migration groups
- Convert UserSecrets subtests to s.Mocked using gomock- Add expectations for prefetch (GetUserSecret) and CRUD paths- Aligns with recent mocked migrations for CryptoKeys/DBCrypt
b615cb1
tod5f03c2
CompareUh oh!
There was an error while loading.Please reload this page.
Emyrk approved these changesAug 20, 2025
d536b91
intomain 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tocoder/internal#869