Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd): add support for external agents to API's and provisioner#19286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kacpersaw merged 14 commits intomainfromkacpersaw/feat-coder-attach-api
Aug 19, 2025

Conversation

@kacpersaw
Copy link
Contributor

@kacpersawkacpersaw commentedAug 11, 2025•
edited
Loading

This pull request introduces support for external workspace management, allowing users to register and manage workspaces that are provisioned and managed outside of the Coder.

Depends on:coder/terraform-provider-coder#424

  • GET /api/v2/init-script - Gets the agent initialization script
    • By default, it returns a script for Linux (amd64), but with query parameters (os and arch) you can get the init script for different platforms
  • GET /api/v2/workspaces/{workspace}/external-agent/{agent}/credentials - Gets credentials for an external agent(enterprise)
  • Updated queries to filter workspaces/templates by the has_external_agent field

@kacpersawkacpersaw changed the titlefeat: add support for external agents to API's and provisionerfeat(coderd): add support for external agents to API's and provisionerAug 11, 2025
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-api branch fromb641ffe to07a9c42CompareAugust 11, 2025 15:40
@kacpersawkacpersaw marked this pull request as ready for reviewAugust 12, 2025 06:43
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Proto changes look fine to me 👍

@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-database branch fromc012284 to63fefbbCompareAugust 12, 2025 12:44
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-api branch from60cccc2 to0cf5381CompareAugust 12, 2025 12:44
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-database branch from63fefbb to6033188CompareAugust 13, 2025 10:42
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-api branch from4e94ed6 to5a0bf15CompareAugust 13, 2025 10:42
@deansheatherdeansheather self-requested a reviewAugust 13, 2025 11:20
// which will return all workspaces.
Valid:values.Has("outdated"),
}
filter.HasAITask=parser.NullableBoolean(values, sql.NullBool{},"has-ai-task")
Copy link
Member

@deansheatherdeansheatherAug 13, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you also file a ticket to fixhas-ai-task?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

deansheather reacted with thumbs up emoji
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just minor additions to my previous comments

@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-database branch from6033188 to9e885feCompareAugust 13, 2025 12:08
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-api branch from5a0bf15 toed93d09CompareAugust 13, 2025 12:08
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-api branch frombcd7ad2 toc143ef7CompareAugust 18, 2025 12:52
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-database branch from9e885fe to5a1b1edCompareAugust 18, 2025 12:52
@kacpersawGraphite App
Copy link
ContributorAuthor

kacpersaw commentedAug 19, 2025•
edited
Loading

Merge activity

  • Aug 19, 8:29 AM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Aug 19, 8:31 AM UTC:Graphite rebased this pull request as part of a merge.
  • Aug 19, 8:41 AM UTC:@kacpersaw merged this pull request withGraphite.

@kacpersawkacpersaw changed the base branch fromkacpersaw/feat-coder-attach-database tographite-base/19286August 19, 2025 08:29
@kacpersawkacpersaw changed the base branch fromgraphite-base/19286 tomainAugust 19, 2025 08:30
@kacpersawkacpersawforce-pushed thekacpersaw/feat-coder-attach-api branch fromc143ef7 to0baf2b3CompareAugust 19, 2025 08:30
@kacpersawkacpersaw merged commit9edceef intomainAug 19, 2025
30 of 32 checks passed
@kacpersawkacpersaw deleted the kacpersaw/feat-coder-attach-api branchAugust 19, 2025 08:41
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@spikecurtisspikecurtisAwaiting requested review from spikecurtisspikecurtis is a code owner

@aslilacaslilacAwaiting requested review from aslilac

Assignees

@kacpersawkacpersaw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kacpersaw@johnstcn@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp