- Notifications
You must be signed in to change notification settings - Fork1k
fix: upload the slim binaries from the build directory to the GCS bucket#19281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
.github/workflows/release.yaml Outdated
| slim_binaries=( | ||
| "coder-slim_${version}_darwin_amd64" | ||
| "coder-slim_${version}_darwin_arm64" | ||
| "coder-slim_${version}_linux_amd64" | ||
| "coder-slim_${version}_linux_arm64" | ||
| "coder-slim_${version}_linux_armv7" | ||
| "coder-slim_${version}_windows_amd64.exe" | ||
| "coder-slim_${version}_windows_arm64.exe" | ||
| ) | ||
| # Target array of CLI binary names | ||
| cli_binaries=( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe use an associative array? It's essentially a map. Avoids using two arrays
declare -A binariesbinaries["coder-darwin-amd64"] = "build/coder_slim_${version}-darwin_amd64"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thought about it but I think having two arrays makes it actually more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, change my mind - it's actually nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Adjusted
5d42b18 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The following changes were made: