Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add a divider after Account menu item#1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedMay 31, 2022•
edited
Loading

This PR adds a divider after the Account menu item in the User dropdown.

Subtasks

  • extract UserDropdownContent from UserDropdown: This is done to enable better UI testing via Storybook, separating the content displayed when the menu is open and closed.
  • add a divider after the Account menu item
  • update unit tests and stories for the new component

Fixes#1520

Screenshots

Old

Screen Shot 2022-05-31 at 1 26 14 PM

New

Screen Shot 2022-05-31 at 12 41 00 PM

@AbhineetJain
Copy link
ContributorAuthor

AbhineetJain commentedMay 31, 2022•
edited
Loading

I didn't find any Jest tests that failed, do we have any snapshot tests for our React components, or any other sort of screenshots that need an update? The Storybook forUserDropdown does not contain the menu items, may be we should fix that?

@AbhineetJainAbhineetJain marked this pull request as ready for reviewMay 31, 2022 17:25
@AbhineetJainAbhineetJain requested a review froma team as acode ownerMay 31, 2022 17:25
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this!!!

greyscaled and AbhineetJain reacted with thumbs up emoji
@Kira-Pilot
Copy link
Member

I didn't find any Jest tests that failed, do we have any snapshot tests for our React components, or any other sort of screenshots that need an update? The Storybook forUserDropdown does not contain the menu items, may be we should fix that?

That's a good callout. I think adding a story with the UserDropdown open would be helpful. A quick way to do this might be to add a prop to open the dropdown, and then set that prop totrue in the story. Haven't dug into this very much so lmk if you want to pair!

greyscaled and AbhineetJain reacted with thumbs up emoji

@greyscaled
Copy link
Contributor

@AbhineetJain Thanks this is great - as are your callouts. Would you be down to add a story for this one?

I think it could be the case that our snapshot is always picking up the menu when it's in a closed state.

AbhineetJain reacted with thumbs up emoji

@greyscaled
Copy link
Contributor

greyscaled commentedMay 31, 2022•
edited
Loading

I didn't find any Jest tests that failed, do we have any snapshot tests for our React components, or any other sort of screenshots that need an update? The Storybook forUserDropdown does not contain the menu items, may be we should fix that?

We don't snapshot test with jest - we use Storybook & Chromatic.

We'd see if any snapshots changed or were broken in CI.

Edit:

Screenshot

chromatic

@AbhineetJain
Copy link
ContributorAuthor

@Kira-Pilot@vapurrmaid Thanks for the suggestions. Let me add a new story with the dropdown open.

@AbhineetJainAbhineetJainforce-pushed theabhineetjain/1520-separate-account-menu-item branch 2 times, most recently from31c9145 to1caefa5CompareJune 1, 2022 20:23
@AbhineetJainAbhineetJainforce-pushed theabhineetjain/1520-separate-account-menu-item branch from1caefa5 to926c6ffCompareJune 2, 2022 14:38
@AbhineetJainAbhineetJain merged commit47c7eda intomainJun 2, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/1520-separate-account-menu-item branchJune 2, 2022 15:09
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* add a divider after Account menu item* test: improve Storybook tests* add closed and open userdropdown tests* add default isOpen* extract UserDropdownContent into a single component* remove the isOpen prop* address nit comments* update test name
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate Account from Actions in User Menu
3 participants
@AbhineetJain@Kira-Pilot@greyscaled
[8]ページ先頭
©2009-2025 Movatter.jp