Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: exclude prebuilt workspaces from template-level lifecycle updates#19265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ssncferreira
Copy link
Contributor

@ssncferreirassncferreira commentedAug 8, 2025
edited
Loading

Description

This PR ensures that lifecycle-related changes made via template schedule updates donot affect prebuilt workspaces. Since prebuilds are managed by the reconciliation loop and do not participate in the regular lifecycle executor flow, they must be excluded from any updates triggered by template configuration changes.

This includes changes to TTL, dormant-deletion scheduling, deadline and autostart scheduling.

Changes

  • Updated SQL queryUpdateWorkspacesTTLByTemplateID to exclude prebuilt workspaces
  • Updated SQL queryUpdateWorkspacesDormantDeletingAtByTemplateID to exclude prebuilt workspaces
  • Updated application-layer logic to skip any updates to lifecycle parameters if a workspace is a prebuild
  • Preserved all existing update behavior for regular user workspaces

This change guarantees that only lifecycle-managed workspaces are affected when template-level configurations are modified, preserving strict boundaries between prebuild and user workspace lifecycles.

Related with:

ssncferreira added a commit that referenced this pull requestAug 13, 2025
## DescriptionThis PR ensures that prebuilt workspaces are properly excluded from thelifecycle executor and treated as a separate class of workspaces, fullymanaged by the prebuild reconciliation loop.It introduces two lifecycle guarantees:* When a prebuilt workspace is created (i.e., when the workspace buildcompletes), all lifecycle-related fields are unset, ensuring theworkspace does not participate in TTL, autostop, autostart, dormancy, orauto-deletion logic.* When a prebuilt workspace is claimed, it transitions into a regularuser workspace. At this point, all lifecycle fields are correctlypopulated according to template-level configurations, allowing theworkspace to be managed by the lifecycle executor as expected.## Changes* Prebuilt workspaces now have all lifecycle-relevant fields unsetduring creation* When a prebuild is claimed:* Lifecycle fields are set based on template and workspace levelconfigurations. This ensures a clean transition into the standardworkspace lifecycle flow.* Updated lifecycle-related SQL update queries to explicitly excludeprebuilt workspaces.## Relates Related issue:#18898To reduce the scope of this PR and make the review process moremanageable, the original implementation has been split into thefollowing focused PRs:*#19259*#19263*#19264*#19265These PRs should be considered in conjunction with this one tounderstand the complete set of lifecycle separation changes for prebuiltworkspaces.
@ssncferreirassncferreiraforce-pushed thessncferreira/fix-template-update-ignore-prebuilds branch fromb08282a to10fcd6eCompareAugust 13, 2025 18:12
@ssncferreirassncferreira marked this pull request as ready for reviewAugust 18, 2025 18:06
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, I see existing tests as well inenterprise/coderd/workspaces_test.go relating to testing dormancy deletion only after claiming.

@ssncferreira
Copy link
ContributorAuthor

LGTM, I see existing tests as well inenterprise/coderd/workspaces_test.go relating to testing dormancy deletion only after claiming.

The other tests inworkspace_test.go focus on the claiming process, ensuring that all lifecycle parameters are properly initialized when a prebuild is claimed. By contrast, these tests cover template scheduling updates, verifying that lifecycle parameters are updated on workspaces only after they have been claimed.

@ssncferreirassncferreira merged commitd79a779 intomainAug 19, 2025
30 checks passed
@ssncferreirassncferreira deleted the ssncferreira/fix-template-update-ignore-prebuilds branchAugust 19, 2025 12:08
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

@SasSwartSasSwartAwaiting requested review from SasSwart

Assignees

@ssncferreirassncferreira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ssncferreira@johnstcn@DanielleMaywood

[8]ページ先頭

©2009-2025 Movatter.jp