Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(cli): prevent coder schedule command on prebuilt workspaces#19259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ssncferreira merged 10 commits intomainfromssncferreira/feat-cli-schedule-prebuild
Aug 13, 2025

Conversation

ssncferreira
Copy link
Contributor

@ssncferreirassncferreira commentedAug 8, 2025
edited
Loading

Description

This PR adds CLI-side validation to prevent the use of thecoder schedule command (including bothstart andstop subcommands) on prebuilt workspaces.

Prebuilt workspaces are scheduled independently by the reconciliation loop, based on template and preset-level configuration. They do not participate in the regular user workspace lifecycle, and cannot be configured via thecoder schedule CLI command. This change ensures that attempting to configure scheduling on a prebuilt workspace results in a clear CLI error.

Changes

  • coder schedule start — now returns an error if the target workspace is a prebuild
  • coder schedule stop — now returns an error if the target workspace is a prebuild

Related with:

@ssncferreirassncferreira marked this pull request as ready for reviewAugust 12, 2025 18:08
ssncferreira added a commit that referenced this pull requestAug 13, 2025
## DescriptionThis PR ensures that prebuilt workspaces are properly excluded from thelifecycle executor and treated as a separate class of workspaces, fullymanaged by the prebuild reconciliation loop.It introduces two lifecycle guarantees:* When a prebuilt workspace is created (i.e., when the workspace buildcompletes), all lifecycle-related fields are unset, ensuring theworkspace does not participate in TTL, autostop, autostart, dormancy, orauto-deletion logic.* When a prebuilt workspace is claimed, it transitions into a regularuser workspace. At this point, all lifecycle fields are correctlypopulated according to template-level configurations, allowing theworkspace to be managed by the lifecycle executor as expected.## Changes* Prebuilt workspaces now have all lifecycle-relevant fields unsetduring creation* When a prebuild is claimed:* Lifecycle fields are set based on template and workspace levelconfigurations. This ensures a clean transition into the standardworkspace lifecycle flow.* Updated lifecycle-related SQL update queries to explicitly excludeprebuilt workspaces.## Relates Related issue:#18898To reduce the scope of this PR and make the review process moremanageable, the original implementation has been split into thefollowing focused PRs:*#19259*#19263*#19264*#19265These PRs should be considered in conjunction with this one tounderstand the complete set of lifecycle separation changes for prebuiltworkspaces.
@ssncferreirassncferreira merged commit92d505c intomainAug 13, 2025
28 checks passed
@ssncferreirassncferreira deleted the ssncferreira/feat-cli-schedule-prebuild branchAugust 13, 2025 17:15
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@ssncferreirassncferreira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ssncferreira@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp