Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix!: support empty or default fields when updating templates#19256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rafrdz merged 8 commits intomainfromrafrdz/fix-icon-removed
Aug 12, 2025

Conversation

rafrdz
Copy link

@rafrdzrafrdz commentedAug 8, 2025•
edited
Loading

Breaking change: Field types incodersdk.UpdateTemplateMeta forIcon,Description, andDisplayName moved to*string

Summary

In this pull request we're updating theUpdateTemplateMeta struct to allowDisplayName,Description, andIcon to be set as empty"" or default to the value from the template if not provided in an update call.

Fixes#19036

The bug

The reported bug occurred when clients were attempting to update a metadata field in a template via an edit call. When the request was decoded into anUpdateTemplateMeta struct the default values for fields in the struct were used to update the template even if they weren't provided. This led to fields likeIcon being set to"" (the default value).

Changes

To allow for specific fields to be set to"" these fields were updated to be*string as opposed tostring. This allows for clients to set these fields as"" in an update request or they will default to the template value if they are not provided in the update request (will benil).

Added tests to confirm empty and nil values and updated other tests that use these fields.

Kira-Pilot reacted with hooray emoji
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedAug 8, 2025•
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@rafrdz
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

cdrci2 added a commit to coder/cla that referenced this pull requestAug 8, 2025
@rafrdzrafrdz marked this pull request as ready for reviewAugust 8, 2025 19:31
@rafrdzrafrdz requested a review fromEmyrkAugust 8, 2025 19:33
@rafrdzrafrdz changed the titlefix: support empty or default icons/descriptions when updating templatesfix: support empty or default fields when updating templatesAug 8, 2025
@Emyrk
Copy link
Member

Can we add a! to the title? ->fix!

This is a breaking change for thecodersdk, so we should mark this commit as such.

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LG 👍

Just throw the! in the commit title,fix!:. Add to the description the breaking change is the field types incodersdk.UpdateTemplateMeta foricon,description, anddisplayname moved to*string

Interestingly, the typescript types are unchanged becauseomitempty was included. So the typscript was already correct ❤️

readonlydisplay_name?:string;readonlydescription?:string;readonlyicon?:string;

rafrdz reacted with hooray emoji
@EmyrkEmyrk changed the titlefix: support empty or default fields when updating templatesfix!: support empty or default fields when updating templatesAug 12, 2025
@github-actionsgithub-actionsbot added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelAug 12, 2025
@rafrdzrafrdz merged commitaab2ccd intomainAug 12, 2025
34 checks passed
@rafrdzrafrdz deleted the rafrdz/fix-icon-removed branchAugust 12, 2025 16:37
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 12, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@rafrdzrafrdz

Labels
release/breakingThis label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Templates PATCH request issue
2 participants
@rafrdz@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp