This PR ensures that prebuilt workspaces are properly excluded from the lifecycle executor and treated as a separate class of workspaces, fully managed by the prebuild reconciliation loop.

It introduces two lifecycle guarantees:

When a prebuilt workspace is created (i.e., when the workspace build completes), all lifecycle-related fields are unset, ensuring the workspace does not participate in TTL, autostop, autostart, dormancy, or auto-deletion logic.
When a prebuilt workspace is claimed, it transitions into a regular user workspace. At this point, all lifecycle fields are correctly populated according to template-level configurations, allowing the workspace to be managed by the lifecycle executor as expected.

Changes

Prebuilt workspaces now have all lifecycle-relevant fields unset during creation
When a prebuild is claimed:
Lifecycle fields are set based on template and workspace level configurations. This ensures a clean transition into the standard workspace lifecycle flow.
Updated lifecycle-related SQL update queries to explicitly exclude prebuilt workspaces.

Relates

Related issue:#18898

To reduce the scope of this PR and make the review process more manageable, the original implementation has been split into the following focused PRs:

These PRs should be considered in conjunction with this one to understand the complete set of lifecycle separation changes for prebuilt workspaces.

github-actionsbot assignedssncferreira

Aug 8, 2025

ssncferreira force-pushed thessncferreira/fix-prebuilds-lifecycle-params branch 4 times, most recently fromec09fd8 todd57747Compare

August 8, 2025 11:48

ssncferreira changed the title~~fix: prebuilds lifecycle parameters on creation and claim~~fix: set prebuilds lifecycle parameters on creation and claim

Aug 8, 2025

fix: prebuilds lifecycle parameters on creation and claim

6415069

ssncferreira force-pushed thessncferreira/fix-prebuilds-lifecycle-params branch fromdd57747 to6415069Compare

August 8, 2025 14:34

ssncferreira marked this pull request as ready for review

August 8, 2025 14:34

ssncferreira requested review fromjohnstcn,SasSwart andDanielleMaywood

August 8, 2025 14:44

johnstcn reviewed

Aug 8, 2025

View reviewed changes

coderd/workspaces.go OutdatedShow resolvedHide resolved

coderd/database/queries/workspaces.sql Outdated

		autostart_schedule= $2,
		next_start_at= $3
		WHERE
		id= $1;

Copy link

Member

johnstcnAug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

suggestion: make it impossible by addingAND owner_id != ...

Copy link

ContributorAuthor

ssncferreiraAug 8, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, I wasn’t sure at first whether to enforce it at the database level or just in the application layer, but I agree it makes more sense to make it impossible by adding a DB-level constraint.

Addressed in4c847c9 and I’ve updated the other relevant queries as well to align with it.

ssncferreira mentioned this pull request

Aug 8, 2025

feat(cli): prevent coder schedule command on prebuilt workspaces#19259

Merged

refactor: remove CLI schedule changes

e322671

ssncferreira mentioned this pull request

Aug 8, 2025

fix: prevent activity bump for prebuilt workspaces#19263

Merged

refactor: remove activity bump changes

85d24ab

ssncferreira mentioned this pull request

Aug 8, 2025

fix: disallow lifecycle endpoints for prebuilt workspaces#19264

Merged

ssncferreira added2 commits

August 8, 2025 18:01

refactor: remove lifecycle API endpoint changes

04a481d

refactor: remove template lifecycle update changes

2761b7e

ssncferreira mentioned this pull request

Aug 8, 2025

fix: exclude prebuilt workspaces from template-level lifecycle updates#19265

Merged

Copy link

ContributorAuthor

ssncferreira commentedAug 8, 2025

As suggested, the scope of this PR was reduced by splitting the original implementation into smaller, more focused PRs.

ssncferreira added3 commits

August 8, 2025 19:02

fix: add database constraints to prevent invalid lifecycle fields on …

4c847c9

…prebuilt workspaces

Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…

2bc1070

…uilds-lifecycle-params

Merge remote-tracking branch 'origin/main' into ssncferreira/fix-preb…

c42ef24

…uilds-lifecycle-params

ssncferreira requested a review fromjohnstcn

August 11, 2025 09:19

johnstcn reviewed

Aug 11, 2025

View reviewed changes

coderd/database/queries/workspaces.sql

Comment on lines +521 to +525

		id= $1
		-- Prebuilt workspaces (identified by having the prebuilds system user as owner_id)
		-- are managed by the reconciliation loop, not the lifecycle executor which handles
		-- autostart_schedule and next_start_at
		AND owner_id!='c42fdf75-3097-471c-8c33-fb52454d81c0'::UUID;

Copy link

Member

johnstcnAug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems more related to#19264?

Copy link

ContributorAuthor

ssncferreiraAug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As discussed internally will keep this constraint in this PR as per the PR description:Updated lifecycle-related SQL update queries to explicitly exclude prebuilt workspaces.