- Notifications
You must be signed in to change notification settings - Fork1k
chore: renameservice ->coder_service, removeagent_id label#19241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
service ->coder_service, removeagent_id labelcoderd/coderd.go Outdated
| r.Group(func(r chi.Router) { | ||
| r.Use( | ||
| // Override the request_type for agent rpc traffic. | ||
| httpmw.WithStaticProfilingLabels(pprof.Labels("request_type","agent_rpc")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was pprof'd before, so doing this has the agent stuff in it's own group still.
| ServiceTag="coder_service" | ||
| ServiceHTTPServer="http-api" | ||
| ServiceLifecycles="lifecycle-executor" | ||
| ServiceMetricCollector="metrics-collector" | ||
| ServicePrebuildReconciler="prebuilds-reconciler" | ||
| ServiceTerraformProvisioner="terraform-provisioner" | ||
| RequestTypeTag="coder_request_type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Prefixing these tags withcoder_ to prevent collisions. I think this was causing issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👌
34c46c0 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Pyroscope uses
servicetag for top level distinction. So move ourservice->coder_serviceAlso remove
pproflabels per agent id. This resulted in high cardinality with a new label for each agent.