- Notifications
You must be signed in to change notification settings - Fork1k
fix(site): hide "Show parent apps" when no running or starting devcontainers#19200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me 👍🏻. Would be nice to see a test case that verifies/enforces the behavior though.
Uh oh!
There was an error while loading.Please reload this page.
I've added a storybook but I've noticed it doesn't actually show the devcontainer, and after running storybook in my workspace the existing I've tried fixing this myself, and with the aid of Claude Opus 4.1, but I've not had any luck. I believe the main issue is our component is handling both data fetching and rendering, whereas with other parts of the codebase we follow the pattern: @aslilac Do you think we should follow the same approach here? |
that's one approach, but you can also just mock the query response by setting the
|
1c70d32
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#19199
We now hide the "Show parent apps" button when there are no running or starting devcontainers.