Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): hide "Show parent apps" when no running or starting devcontainers#19200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedAug 6, 2025
edited
Loading

Fixes#19199

We now hide the "Show parent apps" button when there are no running or starting devcontainers.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me 👍🏻. Would be nice to see a test case that verifies/enforces the behavior though.

@DanielleMaywood
Copy link
ContributorAuthor

I've added a storybook but I've noticed it doesn't actually show the devcontainer, and after running storybook in my workspace the existingDevcontainer story doesn't show any either. I think the change that introduceduseAgentContainers may have broken the prior story.

I've tried fixing this myself, and with the aid of Claude Opus 4.1, but I've not had any luck. I believe the main issue is our component is handling both data fetching and rendering, whereas with other parts of the codebase we follow the pattern:FooBar paired with aFooBarView.

@aslilac Do you think we should follow the same approach here?

@aslilac
Copy link
Member

that's one approach, but you can also just mock the query response by setting thequeries parameter on the story. for example:

@DanielleMaywoodDanielleMaywood merged commit1c70d32 intomainAug 6, 2025
25 of 27 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/devcontainer/show-parent-apps branchAugust 6, 2025 17:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@aslilacaslilacAwaiting requested review from aslilacaslilac is a code owner

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: "Show parent apps" button visible but does not do anything
3 participants
@DanielleMaywood@aslilac@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp