- Notifications
You must be signed in to change notification settings - Fork928
fix: derive running ws stop time from deadline#1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Summary:A utility is function is added that answers the question if a workspaceis on.Impact:This is a shared piece of logic in workspace scheduling presentations.In particular it unblocks work in 1779, or at least allows animplementation that shares details with the WorkspaceScheduleBanner.Notes:We could possibly instead return whether the workspace is "ON","UNKNOWN", or "OFF". Maybe a future improvement for that could be madeas the neds arrises.
Summary:When a workspace is on, the remaining time until shutdown needs to bederived from the deadline timestamp, not implied from the TTL
johnstcn approved these changesMay 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
BE ✔️
Comment on lines +8 to +27
| ["delete", "canceled", false], | ||
| ["delete", "canceling", false], | ||
| ["delete", "failed", false], | ||
| ["delete", "pending", false], | ||
| ["delete", "running", false], | ||
| ["delete", "succeeded", false], | ||
| ["stop", "canceled", false], | ||
| ["stop", "canceling", false], | ||
| ["stop", "failed", false], | ||
| ["stop", "pending", false], | ||
| ["stop", "running", false], | ||
| ["stop", "succeeded", false], | ||
| ["start", "canceled", false], | ||
| ["start", "canceling", false], | ||
| ["start", "failed", false], | ||
| ["start", "pending", false], | ||
| ["start", "running", false], | ||
| ["start", "succeeded", true], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💝
Comment on lines +189 to +193
| export const isWorkspaceOn = (workspace: Workspace): boolean => { | ||
| const transition = workspace.latest_build.transition | ||
| const status = workspace.latest_build.job.status | ||
| return transition === "start" && status === "succeeded" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 it's a narrow definition of 'on' but I think that's the correct one.
This resolved#1779 |
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* refactor: isWorkspaceOn utilitySummary:A utility is function is added that answers the question if a workspaceis on.Impact:This is a shared piece of logic in workspace scheduling presentations.In particular it unblocks work in 1779, or at least allows animplementation that shares details with the WorkspaceScheduleBanner.Notes:We could possibly instead return whether the workspace is "ON","UNKNOWN", or "OFF". Maybe a future improvement for that could be madeas the neds arrises.* fix: derive running ws stop time from deadlineSummary:When a workspace is on, the remaining time until shutdown needs to bederived from the deadline timestamp, not implied from the TTL
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When a workspace is on, the remaining time until shutdown needs to be
derived from the deadline timestamp, not implied from the TTL. A utility is
function is added that answers the question if a workspace is on.
Impact:
This is a shared piece of logic in workspace scheduling presentations.
In particular it unblocks work in 1779, or at least allows an
implementation that shares details with the WorkspaceScheduleBanner.
Notes:
We could possibly instead return whether the workspace is "ON",
"UNKNOWN", or "OFF". Maybe a future improvement for that could be made
as the neds arrises.