Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update to node 20.19.4#19188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 7 commits intomainfromlilac/node-20.19
Aug 6, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion.github/actions/setup-node/action.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ runs:
- name: Setup Node
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
with:
node-version: 20.16.0
node-version: 20.19.4
# See https://github.com/actions/setup-node#caching-global-packages-data
cache: "pnpm"
cache-dependency-path: ${{ inputs.directory }}/pnpm-lock.yaml
Expand Down
12 changes: 6 additions & 6 deletionsdogfood/coder/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ FROM rust:slim@sha256:3f391b0678a6e0c88fd26f13e399c9c515ac47354e3cadfee7daee3b21
ENV CARGO_INSTALL_ROOT=/tmp/
# Use more reliable mirrors for Debian packages
RUN sed -i 's|http://deb.debian.org/debian|http://mirrors.edge.kernel.org/debian|g' /etc/apt/sources.list && \
apt-get update || true
apt-get update || true
RUN apt-get update && apt-get install -y libssl-dev openssl pkg-config build-essential
RUN cargo install jj-cli typos-cli watchexec-cli

Expand DownExpand Up@@ -126,8 +126,8 @@ RUN mkdir -p /etc/sudoers.d && \

# Use more reliable mirrors for Ubuntu packages
RUN sed -i 's|http://archive.ubuntu.com/ubuntu/|http://mirrors.edge.kernel.org/ubuntu/|g' /etc/apt/sources.list && \
sed -i 's|http://security.ubuntu.com/ubuntu/|http://mirrors.edge.kernel.org/ubuntu/|g' /etc/apt/sources.list && \
apt-get update --quiet && apt-get install --yes \
sed -i 's|http://security.ubuntu.com/ubuntu/|http://mirrors.edge.kernel.org/ubuntu/|g' /etc/apt/sources.list && \
apt-get update --quiet && apt-get install --yes \
ansible \
apt-transport-https \
apt-utils \
Expand DownExpand Up@@ -245,7 +245,7 @@ RUN DOCTL_VERSION=$(curl -s "https://api.github.com/repos/digitalocean/doctl/rel
ARG NVM_INSTALL_SHA=bdea8c52186c4dd12657e77e7515509cda5bf9fa5a2f0046bce749e62645076d
# Install frontend utilities
ENV NVM_DIR=/usr/local/nvm
ENV NODE_VERSION=20.16.0
ENV NODE_VERSION=20.19.4
RUN mkdir -p $NVM_DIR
RUN curl -o nvm_install.sh https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.0/install.sh && \
echo "${NVM_INSTALL_SHA} nvm_install.sh" | sha256sum -c && \
Expand All@@ -256,8 +256,8 @@ RUN source $NVM_DIR/nvm.sh && \
nvm use $NODE_VERSION
ENV PATH=$NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH
RUN corepack enable && \
corepack prepare npm@10.8.1 --activate && \
corepack prepare pnpm@9.15.1 --activate
corepack prepare npm@10.8.1 --activate && \
corepack prepare pnpm@9.15.1 --activate

RUN pnpx playwright@1.47.0 install --with-deps chromium

Expand Down
2 changes: 1 addition & 1 deletionsite/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,7 @@
"semver": "7.6.2",
"tailwind-merge": "2.6.0",
"tailwindcss-animate": "1.0.7",
"tzdata": "1.0.40",
"tzdata": "1.0.44",
"ua-parser-js": "1.0.40",
"ufuzzy": "npm:@leeoniya/ufuzzy@1.0.10",
"undici": "6.21.2",
Expand Down
10 changes: 5 additions & 5 deletionssite/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ describe("validationSchema", () => {
saturday: false,
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorNoDayOfWeek);
expect(validate).toThrow(Language.errorNoDayOfWeek);
});

it("disallows empty startTime when autostart is enabled", () => {
Expand All@@ -87,7 +87,7 @@ describe("validationSchema", () => {
startTime: "",
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorNoTime);
expect(validate).toThrow(Language.errorNoTime);
});

it("allows startTime 16:20", () => {
Expand All@@ -105,7 +105,7 @@ describe("validationSchema", () => {
startTime: "9:30",
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorTime);
expect(validate).toThrow(Language.errorTime);
});

it("disallows startTime to be HH:m", () => {
Expand All@@ -114,7 +114,7 @@ describe("validationSchema", () => {
startTime: "09:5",
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorTime);
expect(validate).toThrow(Language.errorTime);
});

it("disallows an invalid startTime 24:01", () => {
Expand All@@ -123,7 +123,7 @@ describe("validationSchema", () => {
startTime: "24:01",
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorTime);
expect(validate).toThrow(Language.errorTime);
});

it("disallows an invalid startTime 09:60", () => {
Expand All@@ -132,7 +132,7 @@ describe("validationSchema", () => {
startTime: "09:60",
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorTime);
expect(validate).toThrow(Language.errorTime);
});

it("disallows an invalid timezone Canada/North", () => {
Expand All@@ -141,7 +141,7 @@ describe("validationSchema", () => {
timezone: "Canada/North",
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorTimezone);
expect(validate).toThrow(Language.errorTimezone);
});

it.each<[string]>(timeZones.map((zone) => [zone]))(
Expand All@@ -162,7 +162,7 @@ describe("validationSchema", () => {
ttl: 24 * 7,
};
const validate = () => validationSchema.validateSync(values);
expect(validate).not.toThrowError();
expect(validate).not.toThrow();
});

it("allows a ttl of 30 days", () => {
Expand All@@ -171,7 +171,7 @@ describe("validationSchema", () => {
ttl: 24 * 30,
};
const validate = () => validationSchema.validateSync(values);
expect(validate).not.toThrowError();
expect(validate).not.toThrow();
});

it("disallows a ttl of 30 days + 1 hour", () => {
Expand All@@ -180,7 +180,7 @@ describe("validationSchema", () => {
ttl: 24 * 30 + 1,
};
const validate = () => validationSchema.validateSync(values);
expect(validate).toThrowError(Language.errorTtlMax);
expect(validate).toThrow(Language.errorTtlMax);
});

it("allows a ttl of 1.2 hours", () => {
Expand All@@ -189,7 +189,7 @@ describe("validationSchema", () => {
ttl: 1.2,
};
const validate = () => validationSchema.validateSync(values);
expect(validate).not.toThrowError();
expect(validate).not.toThrow();
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -158,7 +158,7 @@ export const validationSchema = Yup.object({
try {
dayjs.tz(dayjs(), value);
return true;
} catch(e){
} catch {
return false;
}
}),
Expand Down
18 changes: 17 additions & 1 deletionsite/src/utils/timeZones.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,22 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

* Ideally the version of tzdata should correspond to the version of the
* timezone database used by the version of Node we're running our tests
* against. For example, Node v20.19.4 and tzdata@1.0.44 both correspond to
* version 2025b of the ICU timezone:
* https://github.com/nodejs/node/blob/v20.19.4/test/fixtures/tz-version.txt
* https://github.com/rogierschouten/tzdata-generate/releases/tag/v1.0.44
*
* For some reason though, the timezones allowed by `Intl.DateTimeFormat` in
* Node diverged slightly from the timezones present in the tzdata package,
* despite being derived from the same data. Notably, the timezones that we
* filter out below are not allowed by Node as of v20.18.1 and onward–which is
* the version that updated the 20 release line from 2024a to 2024b.
*/
importtzDatafrom"tzdata";

exportconsttimeZones=Object.keys(tzData.zones).sort();
exportconsttimeZones=Object.keys(tzData.zones)
.filter((it)=>it!=="Factory"&&it!=="null")
.sort();

exportconstgetPreferredTimezone=()=>
Intl.DateTimeFormat().resolvedOptions().timeZone;
Loading
[8]ページ先頭
©2009-2025 Movatter.jp