Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add selected template link at the template select field#1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Add the selected template link at the template select field
  • Made a minor refactoring in the forms to make them look more consistent

Closes#1864

Before:
Screen Shot 2022-05-31 at 11 57 47

After:
Screen Shot 2022-05-31 at 11 56 57

@BrunoQuaresmaBrunoQuaresma requested a review froma team as acode ownerMay 31, 2022 14:58
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 31, 2022
@BrunoQuaresma
Copy link
CollaboratorAuthor

It is also related to#1638

Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! What do you think about left aligning that 'Read more' helper text against the left border of the input?

BrunoQuaresma, jsjoeio, and greyscaled reacted with heart emoji
@BrunoQuaresma
Copy link
CollaboratorAuthor

@Kira-Pilot I've been thinking about that and I think it is best and we probably want this for all the text helpers.@vapurrmaid@presleyp@ashmeer7 what do you think?

Kira-Pilot and greyscaled reacted with heart emoji

@BrunoQuaresma
Copy link
CollaboratorAuthor

I was wondering why the text helper for the schedule form was aligned to the left without any extra style, and I found we are using the input as "underline" instead of "contained" in the schedule.@vapurrmaid are you ok if I change the Schedule form to use the default(contained) type for inputs?

@greyscaled
Copy link
Contributor

greyscaled commentedMay 31, 2022•
edited
Loading

I was wondering why the text helper for the schedule form was aligned to the left without any extra style, and I found we are using the input as "underline" instead of "contained" in the schedule.@vapurrmaid are you ok if I change the Schedule form to use the default(contained) type for inputs?

sure - this SGTM 🎉 !

@greyscaled
Copy link
Contributor

@Kira-Pilot I've been thinking about that and I think it is best and we probably want this for all the text helpers.@vapurrmaid@presleyp@ashmeer7 what do you think?

Great suggestions 🙌🏻 !

@BrunoQuaresma
Copy link
CollaboratorAuthor

They look good!
Screen Shot 2022-05-31 at 15 18 09

Kira-Pilot reacted with heart emoji

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)May 31, 2022 18:25
@BrunoQuaresmaBrunoQuaresma merged commit65c17a0 intomainMay 31, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/add-more-info-on-create-workspace-form branchMay 31, 2022 18:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display a template link in the Create Workspace form when the user selects the template.
3 participants
@BrunoQuaresma@greyscaled@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp