Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: cherry-pick coder desktop + corporate vpn fixes for 2.24#19177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 5, 2025
edited
Loading

This backports the coder/coder fixes forcoder/coder-desktop-windows#147 andcoder/coder-desktop-macos#201 to v2.24, and fixes a bug where Coder Desktop logs were duplicated on Windows.

  1. ci: conditionally disable spotlight indexing #19124 (c64b3c0d8327edbfad4cc7bc373bdb873cd7e26b)
    • Required for CI to pass.
  2. ci: bump xcode version to 16.1.0 #19125 (9f2dc72d9a3d9feecf28bc30cd1234394a0e5c37)
    • Required for CI to pass.
  3. ci: set valid xcode version in release script #19143 (914daac2dcf700817d4ae248a6e8014f64654fe7)
    • Required for CI to pass.
  4. chore: add support for tailscale soft isolation in VPN #19023 (618121cba39833db7c1ca4653d7ce7745d5aff57)
  5. chore: remove soft isolation configurability #19069 (ba0b124a1daaddde590f5839afebe803330981be)
  6. fix: avoid duplicating logs on Coder Connect Windows #19052 (19171e27c9624c435f97d4ae5e3b61c649bc7063)
    • Avoid duplicating logs on Coder Desktop Windows
  7. chore: addvpn-daemon run command for macos #19080 (18b037d0086cd6eca11e6180b36a302badaa5a5f)
    • Updates coder/tailscale reference, lets Coder Desktop macOS use the slim binary to run Coder Connect.

I've tested my latest build of Coder Desktop against a Coder server running this branch, just as a sanity check.

johnstcnand others added7 commitsAugust 5, 2025 09:11
Work around for following issue:```Run sudo mdutil -a -i off  sudo mdutil -a -i off  sudo mdutil -X /  sudo launchctl bootout system /System/Library/LaunchDaemons/com.apple.metadata.mds.plist  shell: /bin/bash -e {0}4 files/directories removedBoot-out failed: 5: Input/output error```This can happen if spotlight has already been disabled.
16.0.0 was yanked from the macOS runners, so this will likely need cherry picking into the upcoming release branch.We've already checked everything builds fine on#19125.In a few releases we'll stop building the dylib and also therefore remove xcode as a dependency on coder/coder altogether.
Undoes a lot of the changes in5319d47Keeps the `netns.SetCoderSoftIsolation()` call, but always sets it to`true` when using a TUN device.
The sinks are already added to the logger above, so they're just getting duplicated
Continues to addresscoder/coder-desktop-macos#201Identical to the windows command, except we don't write to stdio. We're retaining the system we have for logging on macOS, where we push logs over the tunnel and use the OS logger. I've tested that a build with this command works end-to-end with my new version of Coder Desktop macOS.Also brings in the soft net isolation changes from `main` of coder/tailscale.
@coderabbitaicoderabbitai

This comment was marked as outdated.

@ethanndicksonethanndickson changed the titleCherry-pick Coder Desktop + Corporate VPN fixes for 2.24chore: cherry-pick coder desktop + corporate vpn fixes for 2.24Aug 5, 2025
@ethanndicksonethanndickson merged commitbc502b5 intorelease/2.24Aug 6, 2025
59 of 61 checks passed
@ethanndicksonethanndickson deleted the ethan/2.24-coder-desktop-cherrypicks branchAugust 6, 2025 03:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@stirbystirbyAwaiting requested review from stirby

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ethanndickson@deansheather@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp