- Notifications
You must be signed in to change notification settings - Fork1k
Cherry-pick for release 2.25#19169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Typos and other errors often result in invalid presets in a template.Coder would import these broken templates and present them to users whenthey create workspaces. An unsuspecting user who chooses a broken presetwould then experience a failed workspace build with no obvious errormessage.This PR adds additional validation beyond what is possible in theTerraform provider schema. Coder will now present a more helpful errormessage to template authors when they upload a new template version:<img width="1316" height="286" alt="Screenshot 2025-07-14 at 12 22 49"src="https://github.com/user-attachments/assets/7f5f778f-d9ae-487a-95e2-f6f1ca604a9c"/>The frontend warning is less helpful right now, but I'd like to addressthat in a follow-up since I need frontend help:<img width="1102" height="616" alt="image"src="https://github.com/user-attachments/assets/e838ffc8-ef4f-428d-9280-74fa0c491666"/>closes#17333<!-- This is an auto-generated comment: release notes by coderabbit.ai-->## Summary by CodeRabbit* **New Features*** Improved validation and error reporting for template presets,providing clearer feedback when presets cannot be parsed or referenceundefined parameters.* **Bug Fixes*** Enhanced error handling during template version creation to betterdetect and report issues with presets.* **Tests*** Added new tests to verify validation of both valid and invalidTerraform presets during template version creation.* Improved test reliability by enabling dynamic control over errorinjection in database-related tests.* **Chores*** Updated a dependency to the latest version for improved stability andfeatures.<!-- end of auto-generated comment: release notes by coderabbit.ai -->(cherry picked from commitf256a23)
16.0.0 was yanked from the macOS runners, so this will likely need cherry picking into the upcoming release branch.We've already checked everything builds fine on#19125.In a few releases we'll stop building the dylib and also therefore remove xcode as a dependency on coder/coder altogether.(cherry picked from commitb95cf47)
Document how to start a remote MCP Coder server. Addressescoder/internal#823.(cherry picked from commita02d1c1)
# Add OAuth2 Provider DocumentationThis PR adds comprehensive documentation for the experimental OAuth2Provider feature, which allows Coder to function as an OAuth2authorization server. The documentation covers:- Feature overview and experimental status warning- Setup requirements and enabling the feature- Methods for creating OAuth2 applications (UI and API)- Integration patterns including standard OAuth2 and PKCE flows- Discovery endpoints and token management- Testing and development guidance- Troubleshooting common issues- Security considerations and current limitationsThe documentation is marked as experimental and includes appropriatewarnings about production usage.Signed-off-by: Thomas Kosiewski <tk@coder.com>(cherry picked from commit247efc0)
Adds the oauth2-provider doc page to the manifest so it's rendered inthe docs, fixes formatting in the oauth2-provider doc, and links to itfrom the MCP doc.To see the formatting issues, visithttps://coder.com/docs/@4bcf44a/admin/integrations/oauth2-provider. Tosee the doc after the fixes, visithttps://coder.com/docs/@f05969a/admin/integrations/oauth2-provider.(cherry picked from commitc94333d)
Work around for following issue:```Run sudo mdutil -a -i off sudo mdutil -a -i off sudo mdutil -X / sudo launchctl bootout system /System/Library/LaunchDaemons/com.apple.metadata.mds.plist shell: /bin/bash -e {0}4 files/directories removedBoot-out failed: 5: Input/output error```This can happen if spotlight has already been disabled.(cherry picked from commit6a35400)
sreya approved these changesAug 4, 2025
e6ec957
intorelease/2.25 26 of 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18844
f256a23a773e235213f6fc53cf5dcf527c0601d8
#19114
b8e2344ef54b1f88af33935f1afb588f566f42a6
#19143
b95cf47f9998e21f8d97c913424f5ec052c4ab19
#19150
a02d1c1e59e2c4c8efa8a802eba04a84bc4af22b
#19165
247efc0dcc7da73cd2ae80ad08d1491c8825c163