- Notifications
You must be signed in to change notification settings - Fork1k
feat: add user_secrets table#19162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some suggestions before I stamp 👍
Overall LG!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
c65996a
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#780
Summary of changes:
user_secrets
tableuser_secrets
table containsenv_name
andfile_path
fields which are not used at the moment, but will be used in later PRsuser_secrets
table doesn't containvalue_key_id
, I will add it in a separate migration in a dbcrypt PRResourceUserSecret
resourceResourceUserSecret
from site-wide permsResourceUserSecret
to user-wide permsResourceUserSecret
from org-wide perms; seems it's not strictly required, becauseResourceUserSecret
is not tied to organization in dbauthz wrappers?allPermsExcept
Main questions:
value_key_id
in dbcrypt PR