- Notifications
You must be signed in to change notification settings - Fork1k
chore(agent/agentcontainers): disable project autostart by default#19114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore(agent/agentcontainers): disable project autostart by default#19114
Uh oh!
There was an error while loading.Please reload this page.
Conversation
We disable the logic that allows autostarting discovered devcontainersby default. We want this behavior to be opt-in rather than opt-out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR disables autostarting of discovered devcontainer projects by default, making this behavior opt-in rather than opt-out for better control over automatic project initialization.
- Adds a new CLI flag
--devcontainers-discovery-autostart-enable(defaults to false) - Wraps autostart logic with a conditional check based on the new setting
- Updates tests to verify the new disabled-by-default behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/testdata/coder_agent_--help.golden | Updates help text to include the new autostart flag documentation |
| cli/agent.go | Adds CLI flag and option configuration for discovery autostart control |
| agent/agentcontainers/api_test.go | Adds test case to verify autostart is disabled by default |
| agent/agentcontainers/api.go | Implements the autostart conditional logic and option setter |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
b8e2344 intomainUh oh!
There was an error while loading.Please reload this page.
We disable the logic that allows autostarting discovered devcontainers by default. We want this behavior to be opt-in rather than opt-out.