- Notifications
You must be signed in to change notification settings - Fork1k
chore(site): add preset combobox to dynamic parameters page#19100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore(site): add preset combobox to dynamic parameters page#19100
Uh oh!
There was an error while loading.Please reload this page.
Conversation
96e32d6 intomainUh oh!
There was an error while loading.Please reload this page.
| // "undefined" string is equivalent to using None option | ||
| // Combobox requires a value in order to correctly highlight the None option | ||
| presetOptions[index].value==="undefined" | ||
| ?undefined | ||
| :presetOptions[index].value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sorry to keep bringing up merged pull requests, but couldn'tvalue just be""? then it wouldn't need this special handling, asundefined gets deserialized the same as"" by the backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@aslilac Ideally, yes, it should be an empty string. However, this appears to be an issue with theCombobox component: when no value is provided, the "None" option doesn't get highlighted on hover like the other options do. This was a workaround to ensure consistent hover behavior, including for the "None" option.
@jaaydenh helped me investigate this and came up with the workaround, so he may have more context.
I've included a recording below showing the difference:
- When value is "": "None" is not highlighted on hover
Screen.Recording.2025-08-04.at.16.09.20.mov
- When value is set: "None" is highlighted on hover
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR updates the
CreateWorkspacePageViewExperimentalpage to use theComboboxReact component for preset selection. This aligns it with the implementation used in the standardCreateWorkspacePageView, ensuring consistency in UI behavior and component usage across both pages.Related to
CreateWorkspacePageViewchanges:#19063