Pull Request Overview

This PR enables template administrators to access and modify their notification preferences for template events through the frontend. Previously, these settings were hidden from users without full deployment configuration access.

• Updated notification filtering logic to show "Template Events" group to users withcreateTemplates permission
• Added mock template event notification templates for testing
• Created a new story for template creators in the notifications page

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

I would like to suggest a different approach:

#19115

Looking at the backend, it seems like user admins also have this exact same issue: by hiding the notifications based on theviewDeploymentConfig we're making it impossible for user admins to disable notifications they are opted into by default. That was always the wrong permission to check here, for both cases. For template notifications it's better to checkcreateTemplates like you've done here, but we should fix users too by checkingcreateUser.

I also don't think that aselect is actually the right place to filter this, because the object wrangling we're doing is very awkward. I think it's easier to just check if a group should be rendered or not by returning early in themap later on. We can just have a little utility function that picks the right permission based on the group name, and if the permission isfalse then wereturn null.

I ended up just doing exactly all of that while looking at the code and pushed it to a branch of my own. If you want to bring that code into this branch you can just go click merge on that PR. I set this PR as the target.

cool, this is much better now 😄 thanks!