Since we changed the icon image to be an ExternalImage withalt={option.displayName}https://github.com/coder/coder/pull/19063/files#diff-f7c0d4d4c43b6dd17458ff44a1a0dfdccfae367b09ffe41fdbe09c48c151e466R126
The name includes both the image alt text (Rust) + the text content (Rust). Let me know if this is ok, or if there is a better way to filter out this element.

Sorry to come in at the last minute (after things have been merged), but these test changes are papering over accessibility problems that the new code introduced. This is especially relevant, as there's a good chance that I'm going to be submitting a VPAT (Voluntary Product Accessibility Template) audit forcoder/coder sometime in H2 for Marketing/GTM

There's a reason why the testing library changed the accessible name to"Rust Rust" – because that's the value that a screen reader will read out to a user who can't see. It's going to be super annoying for the user if they get doubled-up announcements as they cycle through every item in the options list

In my mind, what we can do instead is:

1. Revert the accessible names for the test selectors to remove the duplicated values (so justRust and justGo, rather thanRust Rust andGo Go)
2. Set the alt text to an empty string

Alt text is only valuable if the content of the image isn't strictly decorative, and actually has semantic meaning that other content in the UI isn't capturing. Because we have the name right next to the image, we don't need the alt text. And or UI programming specifically, you can get away with empty alt text more often than you would think

@Parkreiner Thank you for letting me know about this, this is really helpful context 👍

You're right: this PR introducedalt={option.displayName}, which led to the repeated accessible name (e.g. "Rust Rust"). I hadn’t realized that would have a direct impact on screen readers, that's super useful to know.

I’ll go ahead and:

• Revert thealt attribute to use an empty string.
• Update the tests to reflect the correct accessible names without duplication.

Appreciate you taking the time to call this out 🙂