Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(docs): add missing GFM alert directives to blockquotes#19042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aqandrew merged 1 commit intomainfromaqandrew/add-missing-alerts
Jul 28, 2025

Conversation

aqandrew
Copy link
Contributor

I just added support for rendering GFM alerts inside of numbered lists in coder.com (seehttps://github.com/coder/coder.com/pull/328), and noticed that these plain blockquotes should probably be alerts.

This should cover all the missing alerts. I found them by searching for the regex^\s*>\s within docs/**/*.md

Is[!NOTE] the correct type for these? Or do we want to use tip/important/etc?

@github-actionsGitHub Actions
Copy link

github-actionsbot commentedJul 25, 2025•
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@aqandrew
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

matifali reacted with rocket emoji

cdrci2 added a commit to coder/cla that referenced this pull requestJul 25, 2025
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for proactivly fixing these@aqandrew

@aqandrewaqandrew merged commit72b8ab5 intomainJul 28, 2025
27 of 28 checks passed
@aqandrewaqandrew deleted the aqandrew/add-missing-alerts branchJuly 28, 2025 22:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@matifalimatifalimatifali approved these changes

@mtojekmtojekmtojek approved these changes

@EdwardAngertEdwardAngertAwaiting requested review from EdwardAngert

Assignees

@aqandrewaqandrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@aqandrew@johnstcn@matifali@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp