- Notifications
You must be signed in to change notification settings - Fork1k
feat(agent/agentcontainers): allow auto start for discovered containers#19040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -553,7 +553,10 @@ func (api *API) discoverDevcontainersInProject(projectPath string) error { | ||
api.broadcastUpdatesLocked() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. We'll now broadcast updates as we find the dev containers. This makes it feel a little quicker when there is a lot of files being searched through. | ||
if dc.Status == codersdk.WorkspaceAgentDevcontainerStatusStarting { | ||
api.asyncWg.Add(1) | ||
go func() { | ||
defer api.asyncWg.Done() | ||
_ = api.CreateDevcontainer(dc.WorkspaceFolder, dc.ConfigPath) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. nit: I suppose it returns an error, should we log it somewhere? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more.
| ||
}() | ||
} | ||
Uh oh!
There was an error while loading.Please reload this page.