- Notifications
You must be signed in to change notification settings - Fork1k
feat(codersdk/toolsdk): add MCP workspace bash background parameter#19034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
da40c51
to08c72bf
Compare
Could we add a test (similar to the other ones in bash_test.go), that performs two bash tool calls/handler invocations? |
08c72bf
to6463e41
Compare6463e41
toe61cab7
Compare@ThomasK33 I didn't know we had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This needs to be revised to align with Blink's behavior. Specifically, we should capture stdout and stderr until the timeout is reached. After that, the command should continue running in the background, and we will return the captured stdout and stderr as the tool's result.
e61cab7
to3750aee
Compared6ae953
toc29186c
CompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
…nohupChange-Id: If67c30717158bdd84e9f733b56365af7c8d0b51aSigned-off-by: Thomas Kosiewski <tk@coder.com>
c29186c
tod920c64
Compareb666d52
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Addressescoder/internal#820. I'm not sure how I could go about adding automated tests for this, so I only tested manually.
Screen.Recording.2025-07-24.at.15.11.54.mov