Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(codersdk/toolsdk): add MCP workspace bash background parameter#19034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 3 commits intomainfromhugodutka/workspace-bash-bg-param
Jul 29, 2025

Conversation

hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedJul 24, 2025
edited
Loading

Addressescoder/internal#820. I'm not sure how I could go about adding automated tests for this, so I only tested manually.

Screen.Recording.2025-07-24.at.15.11.54.mov

@ThomasK33Graphite App
Copy link
Member

adding automated tests

Could we add a test (similar to the other ones in bash_test.go), that performs two bash tool calls/handler invocations?
One would launch a python http server on port 8123, and the second handler call would curl that port and check if it received an error.

hugodutka reacted with thumbs up emoji

@hugodutkahugodutkaforce-pushed thehugodutka/workspace-bash-bg-param branch from08c72bf to6463e41CompareJuly 24, 2025 16:57
@hugodutkahugodutka changed the base branch frommain tothomask33/feat_add_timeout_support_to_workspace_bash_toolJuly 24, 2025 16:57
@hugodutkahugodutkaforce-pushed thehugodutka/workspace-bash-bg-param branch from6463e41 toe61cab7CompareJuly 24, 2025 16:57
@hugodutka
Copy link
ContributorAuthor

@ThomasK33 I didn't know we hadsetupWorkspaceForAgent! Thanks for spotting. I added integration tests and temporarily rebased onto your timeout branch until its merged. The tests don't spawn a python server though - I don't want to make our test suite depend on python.

Base automatically changed fromthomask33/feat_add_timeout_support_to_workspace_bash_tool tomainJuly 28, 2025 09:25
Copy link
Member

@ThomasK33ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This needs to be revised to align with Blink's behavior. Specifically, we should capture stdout and stderr until the timeout is reached. After that, the command should continue running in the background, and we will return the captured stdout and stderr as the tool's result.

@hugodutkahugodutkaforce-pushed thehugodutka/workspace-bash-bg-param branch frome61cab7 to3750aeeCompareJuly 28, 2025 09:37
@ThomasK33ThomasK33force-pushed thehugodutka/workspace-bash-bg-param branch 3 times, most recently fromd6ae953 toc29186cCompareJuly 28, 2025 16:44
…nohupChange-Id: If67c30717158bdd84e9f733b56365af7c8d0b51aSigned-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33force-pushed thehugodutka/workspace-bash-bg-param branch fromc29186c tod920c64CompareJuly 29, 2025 13:15
@hugodutkahugodutka merged commitb666d52 intomainJul 29, 2025
26 checks passed
@hugodutkahugodutka deleted the hugodutka/workspace-bash-bg-param branchJuly 29, 2025 14:20
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

Assignees

@hugodutkahugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugodutka@ThomasK33

[8]ページ先頭

©2009-2025 Movatter.jp