- Notifications
You must be signed in to change notification settings - Fork1k
feat: support shift+enter in terminal#19021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5fd3af9 to1ad508fCompareIt acts the same alt+enter, but is more familiar to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All good. Just a few comments.
| .withBackoff(newExponentialBackoff(1000,6)) | ||
| .build(); | ||
| websocket.binaryType="arraybuffer"; | ||
| websocketRef.current=websocket; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why do you need to do this? It looks strange to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
attachCustomKeyEventHandler has no disposer, so we can only add it once, which means I have to do it when we create the terminal (if I did it here we would create additional handlers on every reconnect). But that means I need a stable reference to the websocket.
Is there another way of doing this maybe?
Uh oh!
There was an error while loading.Please reload this page.
558e25d intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
It acts the same alt+enter, but is more familiar to users.
Closes#18864