Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: enforce min and max bounds on workspace TTL and Deadline#1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromcj/gh-1758/workspace-ttl-bound
May 30, 2022

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMay 30, 2022
edited
Loading

This adds enforcement for both workspace TTL and deadline:

  • Workspace TTL must be at least one minute and at most 7 days
  • Delta between requested workspace deadline and now must be positive, at lest one minute, and at most 24 hours.

NOTE: These upper bounds are chosen arbitrarily; then can be changed later. The main takeaway here is that it is easier tomodify an existing upper bound than it is to add a new one.

Closes#1758

@johnstcnjohnstcn requested a review froma teamMay 30, 2022 16:32
@johnstcnjohnstcn self-assigned thisMay 30, 2022
@johnstcnjohnstcn merged commita8ae9b3 intomainMay 30, 2022
@johnstcnjohnstcn deleted the cj/gh-1758/workspace-ttl-bound branchMay 30, 2022 19:19
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* Enforces upper bound for workspace TTL* Enforces upper bound for workspace deadline
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: autostop: set upper bound on workspace TTL
2 participants
@johnstcn@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp