- Notifications
You must be signed in to change notification settings - Fork1k
feat: add multiple API key scopes support with granular permissions#19015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
ThomasK33 wants to merge1 commit intothomask33/07-15-fix_oauth2_allow_custom_uri_schemes_without_reverse_domain_notation_for_native_appsChoose a base branch
base:thomask33/07-15-fix_oauth2_allow_custom_uri_schemes_without_reverse_domain_notation_for_native_apps
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJul 23, 2025
This was referencedJul 23, 2025
MemberAuthor
ThomasK33 commentedJul 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
Comment on lines +177 to +187
| Site:Permissions(map[string][]policy.Action{ | ||
| ResourceWorkspace.Type: {policy.ActionRead,policy.ActionCreate,policy.ActionUpdate,policy.ActionDelete}, | ||
| }), | ||
| Org:map[string][]Permission{ | ||
| ResourceWorkspace.Type: { | ||
| {ResourceType:ResourceWorkspace.Type,Action:policy.ActionRead}, | ||
| {ResourceType:ResourceWorkspace.Type,Action:policy.ActionCreate}, | ||
| {ResourceType:ResourceWorkspace.Type,Action:policy.ActionUpdate}, | ||
| {ResourceType:ResourceWorkspace.Type,Action:policy.ActionDelete}, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Org level does not make sense inScope. Just keep it all at the site level.
Remove theorg permissions here and the others
Change-Id: I5857fd833f8114d53f575b9fa48a8e5e7dbfdb2cSigned-off-by: Thomas Kosiewski <tk@coder.com>
7d68b72 tof7d7de0Compare99e7a7b toc2346ffCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I5857fd833f8114d53f575b9fa48a8e5e7dbfdb2c
Signed-off-by: Thomas Kosiewskitk@coder.com