Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add multiple API key scopes support with granular permissions#19015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ThomasK33
Copy link
Member

Change-Id: I5857fd833f8114d53f575b9fa48a8e5e7dbfdb2c
Signed-off-by: Thomas Kosiewskitk@coder.com

@ThomasK33Graphite App
Copy link
MemberAuthor

ThomasK33 commentedJul 23, 2025•
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
Learn more

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

Comment on lines +177 to +187
Site:Permissions(map[string][]policy.Action{
ResourceWorkspace.Type: {policy.ActionRead,policy.ActionCreate,policy.ActionUpdate,policy.ActionDelete},
}),
Org:map[string][]Permission{
ResourceWorkspace.Type: {
{ResourceType:ResourceWorkspace.Type,Action:policy.ActionRead},
{ResourceType:ResourceWorkspace.Type,Action:policy.ActionCreate},
{ResourceType:ResourceWorkspace.Type,Action:policy.ActionUpdate},
{ResourceType:ResourceWorkspace.Type,Action:policy.ActionDelete},
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Org level does not make sense inScope. Just keep it all at the site level.
Remove theorg permissions here and the others

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJul 31, 2025
Change-Id: I5857fd833f8114d53f575b9fa48a8e5e7dbfdb2cSigned-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33ThomasK33 removed the staleThis issue is like stale bread. labelAug 12, 2025
@ThomasK33ThomasK33 assignedEmyrk and unassignedThomasK33Aug 12, 2025
@ThomasK33ThomasK33 reopened thisAug 12, 2025
@ThomasK33ThomasK33force-pushed thethomask33/07-19-feat_add_multiple_api_key_scopes_support_with_granular_permissions branch from7d68b72 tof7d7de0CompareAugust 12, 2025 16:34
@ThomasK33ThomasK33force-pushed thethomask33/07-15-fix_oauth2_allow_custom_uri_schemes_without_reverse_domain_notation_for_native_apps branch from99e7a7b toc2346ffCompareAugust 12, 2025 16:34
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelAug 20, 2025
@EmyrkEmyrk reopened thisAug 24, 2025
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelAug 25, 2025
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelSep 1, 2025
@ThomasK33ThomasK33 deleted the thomask33/07-19-feat_add_multiple_api_key_scopes_support_with_granular_permissions branchSeptember 15, 2025 07:52
@ThomasK33ThomasK33 restored the thomask33/07-19-feat_add_multiple_api_key_scopes_support_with_granular_permissions branchSeptember 15, 2025 07:53
@EmyrkEmyrk reopened thisOct 6, 2025
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsOct 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@EmyrkEmyrkEmyrk left review comments

@aslilacaslilacAwaiting requested review from aslilacaslilac will be requested when the pull request is marked ready for reviewaslilac is a code owner

Assignees

@EmyrkEmyrk

Labels

staleThis issue is like stale bread.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasK33@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp