- Notifications
You must be signed in to change notification settings - Fork1k
feat: make dynamic parameters opt-in by default for new templates#19006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
35 commits Select commitHold shift + click to select a range
532218e feat: make dynamic parameters opt-in by default for new templates
jaaydenh2ec5806 fix: format
jaaydenhb933efe fix: fix stories
jaaydenh7144f4f chore: update warning content
jaaydenh170c5c6 chore: cleanup
jaaydenh9bbd2b2 flip golden default value
Emyrkf25a9f8 chore: echo provisioner reponses to include terraform to match
Emyrkb10945c fixup! chore: echo provisioner reponses to include terraform to match
Emyrk67dc627 fixup! fixup! chore: echo provisioner reponses to include terraform t…
Emyrk9eeb11b fix: use classic parameter flow for MockWorkspace
jaaydenh7aa393c sane defaultS
Emyrk238df67 sane defaultS
Emyrkee116fb fixup! sane defaultS
Emyrkd6a2262 fixup! fixup! sane defaultS
Emyrkcf8deb0 restart and ephemeral parameters resolved
Emyrkfc7b5d7 fixup! restart and ephemeral parameters resolved
Emyrkadce52e add todo to fix this later
Emyrka2358bf fix: fix storybook tests
jaaydenh273411a add todo to fix this later
Emyrk0501cff add todo to fix this later
Emyrkb7064c0 default orphaned template versions to dynamic params
Emyrkfdbf0eb add migration to make data schema consistent
Emyrk326d2bf fixup! add migration to make data schema consistent
Emyrk83e643d make fmt
Emyrkccb76a4 fixup tag tests
Emyrkc4f4fe5 parameters require names
Emyrk95f53fd fix(e2e): disable dynamic parameters for updateWorkspace tests
blink-so[bot]9ba0b67 fix: use classic parameters for workspace tests
jaaydenh5cd3e0b fix: fix e2e tests
jaaydenh53b9ec6 fix: fix format
jaaydenh8fb0043 fix form type
Emyrkf88a934 fix test race
Emyrk1aad58e test fixes
Emyrk5f1320c formatting
Emyrk9c4aa40 remove unused file
EmyrkFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
sane defaultS
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit7aa393cdb6cebff37a62c9ff788e74b88faa5fc9
There are no files selected for viewing
6 changes: 3 additions & 3 deletionscoderd/workspaces_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.