Reviewing files that changed from the base of the PR and betweenf41275e anda62ba63.

• coderd/database/dbgen/dbgen.go (1 hunks)
• coderd/insights_test.go (2 hunks)
• coderd/templates.go (1 hunks)
• coderd/templates_test.go (2 hunks)
• site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx (1 hunks)
• site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.tsx (1 hunks)
• site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx (3 hunks)
• site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx (1 hunks)
• site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx (4 hunks)
• site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx (2 hunks)
• site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx (1 hunks)
• site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersForm.tsx (4 hunks)
• site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPage.tsx (5 hunks)
• site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageExperimental.tsx (2 hunks)
• site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx (1 hunks)
• site/src/testHelpers/entities.ts (2 hunks)

• GitHub Check: test-e2e
• GitHub Check: test-go-race-pg
• GitHub Check: build-dylib
• GitHub Check: test-go-pg-17
• GitHub Check: test-go-pg (windows-2022)
• GitHub Check: test-go-pg (macos-latest)
• GitHub Check: test-go-pg (ubuntu-latest)
• GitHub Check: chromatic
• GitHub Check: gen

coderd/database/dbgen/dbgen.go (1)

150-151:Auditdbgen.Template calls for missingUseClassicParameterFlow
The previous script misparsed file paths (it included the code line in the filename). Please use the following to correctly extractfile:line and then scan the next ~20 lines forUseClassicParameterFlow:

#!/usr/bin/env bash# Find dbgen.Template invocations without UseClassicParameterFlow configured.rg --type go -n'dbgen\.Template'|while IFS=":"read -r file line _;doif! sed -n"${line},$((line+20))p""$file"| grep -q'UseClassicParameterFlow';thenecho"$file:$line"fidone| head

Rerun this and audit any test that now depends on the flipped default.

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx (1)

33-34:Storybook arg looks good

AddingtemplatePermissions keeps the stories compiling with the new prop signature – no issues spotted.

coderd/insights_test.go (1)

1560-1564:Good practice with explanatory comment.

Excellent approach to explicitly setUseClassicParameterFlow: true with a clear comment explaining why this override is necessary for the test's parameter usage tracking functionality. This ensures the test remains functional despite the default value change.

coderd/templates_test.go (2)

80-80:LGTM: Test assertion correctly updated for new default.

The test assertion has been properly updated to expectfalse forUseClassicParameterFlow, which aligns with the PR objective of making dynamic parameters the default for new templates.

---

1554-1554:LGTM: Default expectation correctly updated.

The assertion correctly expectsfalse as the default value forUseClassicParameterFlow, confirming that dynamic parameters are now enabled by default for new templates. The comment clearly documents this behavior change.

site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageExperimental.tsx (2)

229-229:LGTM: Documentation link updated to canonical path.

The documentation link has been cleanly updated from a fragment-based URL to a dedicated dynamic parameters path, improving maintainability and user experience.

---

264-266:LGTM: Consistent documentation link update.

The EmptyState documentation link has been updated to match the same canonical dynamic parameters path, maintaining consistency across the component.

site/src/pages/TemplateSettingsPage/TemplateGeneralSettingsPage/TemplateSettingsForm.tsx (3)

248-248:LGTM: UI label appropriately updated to reflect recommended option.

The addition of "(recommended)" to the dynamic parameters label clearly communicates the preferred choice to users, aligning with the PR's objective of making dynamic parameters the default.

---

252-256:LGTM: Helper text updated to reflect new default behavior.

The updated helper text effectively communicates:

• Dynamic parameters as the default for new templates
• Additional capabilities (form types, conditional parameters)
• Future deprecation of classic flow

This provides clear guidance to users about the direction of the platform.

---

261-261:LGTM: Documentation link updated to canonical path.

The documentation link has been updated to the cleaner, dedicated dynamic parameters path, improving consistency across the application.

site/src/testHelpers/entities.ts (1)

1392-1392:LGTM – flag value updated to reflect new default
The workspace mock correctly mirrors the template’s default (false). ✅

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx (4)

30-30:LGTM: Clean import of the new deprecation warning component.

The import is properly structured and follows the project's naming conventions.

---

70-70:LGTM: Proper TypeScript interface extension.

The newtemplatePermissions prop is correctly typed with the expected structure.

---

96-96:LGTM: Consistent prop destructuring.

The new prop is properly destructured in the component signature.

---

251-255:LGTM: Proper component integration with correct props.

The deprecation warning component is well-positioned between the header and main form, and receives the appropriate props from the template and permissions data.

site/src/pages/CreateWorkspacePage/CreateWorkspacePage.tsx (4)

72-85:LGTM: Well-structured authorization query for template permissions.

The query follows the established pattern for permission checks and correctly uses the template ID as the resource identifier. The enablement condition ensures the query only runs when template data is available.

---

107-107:LGTM: Proper integration of new query into loading state.

The loading state correctly includes the new permissions query alongside existing queries.

---

110-113:LGTM: Consistent error handling pattern.

The error handling follows the existing pattern of using nullish coalescing to check multiple query errors.

---

229-231:LGTM: Type-safe prop passing with proper assertion.

The template permissions data is correctly passed to the view component with appropriate type assertion, following the same pattern as other permission data.

site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.test.tsx (3)

4-7:LGTM: Appropriate mocking of navigation dependencies.

The navigation modules are properly mocked with consistent return values for testing.

---

17-27:Good test coverage for enabled state.

The test properly verifies that the warning text and action link are rendered when the component is enabled.

---

29-38:LGTM: Proper test for disabled state.

The test correctly verifies that nothing is rendered when the component is disabled.

site/src/modules/workspaces/ClassicParameterFlowDeprecationWarning/ClassicParameterFlowDeprecationWarning.tsx (4)

6-10:LGTM: Well-defined TypeScript interface.

The props interface is clear and uses appropriate types for the component's requirements.

---

15-19:LGTM: Proper conditional rendering pattern.

The early return for disabled state is clean and follows React best practices.

---

21-23:LGTM: Clean link generation logic.

The template settings URL is constructed properly using the navigation utilities.

---

26-35:LGTM: Proper use of modern styling and component structure.

The component correctly uses Tailwind CSS classes (following the learning about avoiding Emotion) and maintains a clean Alert + Link structure.

site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersForm.tsx (4)

17-17:LGTM: Consistent import of deprecation warning component.

The import follows the same pattern used in other files.

---

37-37:LGTM: Proper optional prop typing.

The templatePermissions prop is correctly typed as optional with undefined, allowing for graceful handling when permissions aren't available.

---

51-51:LGTM: Consistent prop destructuring.

The templatePermissions prop is properly added to the destructuring pattern.

---

87-91:LGTM: Well-positioned deprecation warning with proper fallback.

The warning component is appropriately placed after the workspace disabled alert and uses nullish coalescing to provide a safe fallback when templatePermissions is undefined.

Also applies to: 92-96

site/src/pages/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPage.tsx (3)

54-67:LGTM! Well-structured permission query implementation.

The template permissions query follows the established pattern used for workspace permissions and correctly implements conditional enabling. The authorization check structure is appropriate for template update permissions.

---

69-71:LGTM! Consistent type casting pattern.

The type assertion follows the same pattern used for the existingpermissions variable and correctly handles the potential undefined state.

---

82-82:LGTM! Proper prop threading implementation.

ThetemplatePermissions prop is correctly added to the type definitions, component signatures, and passed through the component hierarchy without any mutations. This follows React best practices and maintains type safety throughout.

Also applies to: 117-117, 130-130, 154-154