- Notifications
You must be signed in to change notification settings - Fork928
feat: Refactor CLI config-ssh to improve UX#1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
38 commits Select commitHold shift + click to select a range
b7f2b3d feat: Refactor CLI config-ssh to improve UX
mafredri4f03415 chore: Switch to github.com/pkg/diff for diffing
mafredrie196920 fix: Output absolute paths for diffs
mafredricdcf6c3 chore: Remove todone
mafredri263d823 chore: Rename actions => changes for consistency
mafredri18797e7 fix: Remove workspaces check, removing is a legit use-case
mafredri9680792 fix: Remove unused else
mafredri7a4b8d6 fix: Handle no workspaces case
mafredrie552e84 chore: Update diffBytes comment
mafredri5250a8a fix: Cleanup temp file on failure
mafredri0749e58 fix: Wrap error
mafredrib3f448a fix: Enable color when terminal is a tty
mafredric5f1983 fix: Improve output, detect if stdout is tty
mafredri8d0f72c fix: Add Include to the top of config, verify semantically
mafredrid7838b5 fix: Guard against overwriting unknown ~/.ssh/coder file
mafredrif94bc3f feat: Parse and prompt to re-use previous configuration
mafredri00a8c12 chore: Increase indentation
mafredrie50c4c3 chore: Remove unused equality func
mafredri94c8681 fix: Perform multi line regexp matches
mafredri1e33886 fix: Only rewrite coder file path if not ~/
mafredri209c8ff fix: Allow removing invalid Include coder entry
mafredri5ed5e0e Revert "chore: Remove unused equality func"
mafredri000c9b4 fix: Allow replacing default ssh config file in tests
mafredri9d64680 feat: Update options prompt, default to using new options
mafredria7cb149 fix: Improve regexes
mafredria77c791 feat: Add tests
mafredri5bcd038 fix: Do not prompt for previous opts on first run
mafredri1632eb4 fix: Fix broken TestConfigSSH test
mafredri99693ce fix: Revert multiwriter change usued while testing
mafredrifb24742 fix: Change diff suggestions for more natural sentence
mafredri5c785dd fix: Typo
mafredric60762f fix: Fix linting (gocyclo, revive), improve responsiveness
mafredri0422e71 chore: Update header comment
mafredri6e1e1a0 chore: Extract function
mafredrifda935f chore: Remove test log statements
mafredrif1be4c6 Make Include regexp stricter to avoid deleting user data
mafredribf4596c chore: Update the "Changes" text for diff to match non-diff mode
mafredri093e2ce chore: Use consistent naming of functions
mafredriFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.